linux-kernel - RE: [PATCH] selftests/resctrl: Return MBA check result and make it to output message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYAPR01MB63306CF2660A3D7937C37D618B559@TYAPR01MB6330.jpnprd01.prod.outlook.com>
Date:   Tue, 27 Sep 2022 08:55:42 +0000
From:   "tan.shaopeng@...itsu.com" <tan.shaopeng@...itsu.com>
To:     'Reinette Chatre' <reinette.chatre@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Shuah Khan <shuah@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: RE: [PATCH] selftests/resctrl: Return MBA check result and make it to
 output message

Hi Reinette,

Thanks for your advice.

> On my side this patch arrived as an unnumbered sixth patch forming part of a
> five patch series.

In next version, I will add this patch into patch series.

> On 9/13/2022 6:51 PM, Shaopeng Tan wrote:
> > Since MBA check result is not returned, the MBA test result message is
> > always output as OK regardless of whether the MBA check result is true
> > or fail.
> 
> fail -> false?

It is false.

> I think it should be either succeed/fail or true/false.
> 
> >
> > Make output message to be "not ok" if MBA check result is failed.
> >
> > This patch is based on Linux v6.0-rc5
> 
> This should not be part of the changelog but instead be below the "---".

Thanks.

> >
> > Signed-off-by: Shaopeng Tan <tan.shaopeng@...fujitsu.com>
> > ---
> 
> Thank you very much for catching this. The fix looks good, I only have nitpicks
> about the changelog.
> 
> Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Thanks.

Best Regards,
Shaopeng