linux-kernel - Re: [PATCH v5] cpu/hotplug: Do not bail-out in DYING/STARTING sections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzLLBBRiwuQnD2zc@google.com>
Date:   Tue, 27 Sep 2022 11:05:56 +0100
From:   Vincent Donnefort <vdonnefort@...gle.com>
To:     Thorsten Leemhuis <regressions@...mhuis.info>
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        vschneid@...hat.com, kernel-team@...roid.com,
        Derek Dolney <z23@...teo.net>, peterz@...radead.org
Subject: Re: [PATCH v5] cpu/hotplug: Do not bail-out in DYING/STARTING
 sections

On Tue, Sep 20, 2022 at 11:59:06AM +0200, Thorsten Leemhuis wrote:
> On 17.08.22 11:46, Thorsten Leemhuis wrote:
> > 
> > Hi, this is your Linux kernel regression tracker.
> > 
> > On 25.07.22 11:59, Vincent Donnefort wrote:
> >> The DYING/STARTING callbacks are not expected to fail. However, as reported
> >> by Derek, drivers such as tboot are still free to return errors within
> >> those sections, which halts the hot(un)plug and leaves the CPU in an
> >> unrecoverable state.
> >>
> >> No rollback being possible there, let's only log the failures and proceed
> >> with the following steps. This restores the hotplug behaviour prior to
> >> commit 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
> >>
> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215867
> >> Fixes: 453e41085183 ("cpu/hotplug: Add cpuhp_invoke_callback_range()")
> >> Reported-by: Derek Dolney <z23@...teo.net>
> >> Signed-off-by: Vincent Donnefort <vdonnefort@...gle.com>
> >> Tested-by: Derek Dolney <z23@...teo.net>
> > 
> > What's the status here? Did that patch to fixing a regression fall
> > through the cracks? It looks like nothing happened for 3 weeks now,
> > that's why I wondered, but maybe I missed something.
> 
> Hmm, Vincent seems to be MIA, at least I see no recent messages from him
> on lore. Odd. But well, it's still a fix for a regression and it's up to
> v5 already; Valentin already added his Reviewed-by, too. Would be a
> shame to waste this.
> 
> Thomas, could you maybe take a look at the patch?  Maybe we're lucky and
> the patch is already good to go...
> 
> Ciao, Thorsten
> 
> #regzbot poke

Hi Thorsten,

AFAIK, this patch is still valid. I don't think I do have any further action on
that though.

[...]