linux-kernel - Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2022 14:38:11 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc:     Bjorn Helgaas <helgaas@...nel.org>, cgel.zte@...il.com,
        robh@...nel.org, kw@...ux.com, bhelgaas@...gle.com,
        rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, linux-pci@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result
 variable

On Tue, Sep 27, 2022 at 02:07:52PM +0200, Lorenzo Pieralisi wrote:
> [+Greg]
> 
> On Tue, Sep 06, 2022 at 04:25:20PM -0500, Bjorn Helgaas wrote:
> > On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte@...il.com wrote:
> > > From: ye xingchen <ye.xingchen@....com.cn>
> > > 
> > > Return the value iproc_pcie_setup_ib() directly instead of storing it in
> > > another redundant variable.
> > > 
> > > Reported-by: Zeal Robot <zealci@....com.cn>
> > > Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> > 
> > This patch itself is fine, but was posted by cgel.zte@...il.com, not by
> > "ye xingchen <ye.xingchen@....com.cn>", so it needs another signoff
> > and full name so the chain is complete.  For more details see:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.18#n363
> 
> Greg, Bjorn,
> 
> I believe that appending a SoB like this myself is fine:
> 
> Signed-off-by: CGEL ZTE <cgel.zte@...il.com>
> 
> It is a SOB already in kernel commit logs - I assume
> that's the right thing to do in this case, please
> let me know if it isn't and what should we do instead.

Please just drop all patches submitted by this email address and from
zte.com.cn at this point in time as we are unable to actually determine
that they are coming from the correct developers.

Also there's no feedback from them at all, which means no one is
actually reading the email it is being purported to be sent from, which
means it should be dropped no matter what anyway.

thanks,

greg k-h