linux-kernel - Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result variable

Open Source and information security mailing list archives

Message-ID: <YzLnmGiU7qcWkeH2@lpieralisi>
Date:   Tue, 27 Sep 2022 14:07:52 +0200
From:   Lorenzo Pieralisi <lpieralisi@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>, gregkh@...uxfoundation.org
Cc:     cgel.zte@...il.com, robh@...nel.org, kw@...ux.com,
        bhelgaas@...gle.com, rjui@...adcom.com, sbranden@...adcom.com,
        bcm-kernel-feedback-list@...adcom.com, linux-pci@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        ye xingchen <ye.xingchen@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] PCI: iproc: Remove the unneeded result
 variable

[+Greg]

On Tue, Sep 06, 2022 at 04:25:20PM -0500, Bjorn Helgaas wrote:
> On Tue, Sep 06, 2022 at 07:16:36AM +0000, cgel.zte@...il.com wrote:
> > From: ye xingchen <ye.xingchen@....com.cn>
> > 
> > Return the value iproc_pcie_setup_ib() directly instead of storing it in
> > another redundant variable.
> > 
> > Reported-by: Zeal Robot <zealci@....com.cn>
> > Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> 
> This patch itself is fine, but was posted by cgel.zte@...il.com, not by
> "ye xingchen <ye.xingchen@....com.cn>", so it needs another signoff
> and full name so the chain is complete.  For more details see:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.18#n363

Greg, Bjorn,

I believe that appending a SoB like this myself is fine:

Signed-off-by: CGEL ZTE <cgel.zte@...il.com>

It is a SOB already in kernel commit logs - I assume
that's the right thing to do in this case, please
let me know if it isn't and what should we do instead.

Thanks,
Lorenzo

> Bjorn
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives