linux-kernel - Re: [PATCH 09/15] arm64: dts: qcom: sm6125-sony-xperia: add missing SD CD GPIO functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72a150f1-c91b-cd46-6933-3ef101a428f9@somainline.org>
Date:   Tue, 27 Sep 2022 14:39:21 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/15] arm64: dts: qcom: sm6125-sony-xperia: add missing
 SD CD GPIO functions



On 25.09.2022 13:06, Krzysztof Kozlowski wrote:
> Add default GPIO function to SD card detect pins on SM6125 Sony Xperia,
> as required by bindings:
> 
>   qcom/sm6125-sony-xperia-seine-pdx201.dtb: pinctrl@...000: sdc2-off-state: 'oneOf' conditional failed, one must be fixed:
>     'pins' is a required property
>     'function' is a required property
>     'clk-pins', 'cmd-pins', 'data-pins', 'sd-cd-pins' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts
> index 6a8b88cc4385..9af4b76fa6d7 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts
> @@ -89,6 +89,7 @@ &hsusb_phy1 {
>  &sdc2_off_state {
>  	sd-cd-pins {
>  		pins = "gpio98";
> +		function = "gpio";
>  		drive-strength = <2>;
>  		bias-disable;
>  	};
> @@ -97,6 +98,7 @@ sd-cd-pins {
>  &sdc2_on_state {
>  	sd-cd-pins {
>  		pins = "gpio98";
> +		function = "gpio";
>  		drive-strength = <2>;
>  		bias-pull-up;
>  	};