linux-kernel - Re: [PATCH] ARM: pxa: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzLvMvouCIcXCJlU@debian.me>
Date:   Tue, 27 Sep 2022 19:40:18 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Jilin Yuan <yuanjilin@...rlc.com>
Cc:     daniel@...que.org, haojian.zhuang@...il.com,
        robert.jarzmik@...e.fr, linux@...linux.org.uk,
        linux-arm-kernel@...ts.infradead.orgc, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: pxa: fix repeated words in comments

On Wed, Sep 14, 2022 at 04:37:46PM +0800, Jilin Yuan wrote:
> -/* The actual GPIO offsets get filled in in the palm27x_udc_init() call */
> +/* The actual GPIO offsets get filled in the palm27x_udc_init() call */
>  static struct gpiod_lookup_table palm27x_udc_gpiod_table = {
>  	.dev_id = "gpio-vbus",
>  	.table = {
 
NAK!

The reasons:
  * I read the comment above (without the patch) as "The actual offsets get
    set in the function call". Both ins are of different parts of speech
    (adverbial and preposition).
  * As I stated to other developers (see [1] and [2]), you and other
    @cdjrlc.com developers ignore critical code reviews (no reply to
    them).

Thanks.

[1]: https://lore.kernel.org/lkml/ca8efe3b-1aeb-8a4e-79e9-3f3f9281ff34@gmail.com/
[2]: https://lore.kernel.org/lkml/YzJaIolrTarQ4Qdn@debian.me/

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)