linux-kernel - Re: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df4f1ee5-2123-8b39-fab5-88579c40cb0e@amd.com>
Date:   Wed, 28 Sep 2022 16:05:00 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Mario Limonciello <mario.limonciello@....com>,
        John Allen <john.allen@....com>
Cc:     stable@...r.kernel.org,
        Rijo-john Thomas <Rijo-john.Thomas@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: ccp: Add support for TEE for PCI ID 0x14CA

On 9/28/22 13:45, Mario Limonciello wrote:
> SoCs containing 0x14CA are present both in datacenter parts that
> support SEV as well as client parts that support TEE.
> 
> Cc: stable@...r.kernel.org # 5.15+
> Tested-by: Rijo-john Thomas <Rijo-john.Thomas@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Acked-by: Tom Lendacky <thomas.lendacky@....com>

> ---
>   drivers/crypto/ccp/sp-pci.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
> index 792d6da7f0c0..084d052fddcc 100644
> --- a/drivers/crypto/ccp/sp-pci.c
> +++ b/drivers/crypto/ccp/sp-pci.c
> @@ -381,6 +381,15 @@ static const struct psp_vdata pspv3 = {
>   	.inten_reg		= 0x10690,
>   	.intsts_reg		= 0x10694,
>   };
> +
> +static const struct psp_vdata pspv4 = {
> +	.sev			= &sevv2,
> +	.tee			= &teev1,
> +	.feature_reg		= 0x109fc,
> +	.inten_reg		= 0x10690,
> +	.intsts_reg		= 0x10694,
> +};
> +
>   #endif
>   
>   static const struct sp_dev_vdata dev_vdata[] = {
> @@ -426,7 +435,7 @@ static const struct sp_dev_vdata dev_vdata[] = {
>   	{	/* 5 */
>   		.bar = 2,
>   #ifdef CONFIG_CRYPTO_DEV_SP_PSP
> -		.psp_vdata = &pspv2,
> +		.psp_vdata = &pspv4,
>   #endif
>   	},
>   	{	/* 6 */