linux-kernel - Re: [PATCH v4 2/3] dt-bindings: thermal: add loongson2k thermal binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6b15f31-06e1-81e8-9e4f-5a2b8a704096@loongson.cn>
Date:   Wed, 28 Sep 2022 16:26:36 +0800
From:   Yinbo Zhu <zhuyinbo@...ngson.cn>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     zhanghongchen <zhanghongchen@...ngson.cn>,
        Liu Peibao <liupeibao@...ngson.cn>, zhuyinbo@...ngson.cn
Subject: Re: [PATCH v4 2/3] dt-bindings: thermal: add loongson2k thermal
 binding



在 2022/9/28 下午4:01, Krzysztof Kozlowski 写道:
> On 28/09/2022 05:16, Yinbo Zhu wrote:
>> Add the loongson2k thermal binding with DT schema format using
>> json-schema.
>>
>> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>> +$id: http://devicetree.org/schemas/thermal/loongson,ls2k-thermal.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Thermal sensors on loongson2k SoCs
>> +
>> +maintainers:
>> +  - zhanghongchen <zhanghongchen@...ngson.cn>
>> +  - Yinbo Zhu <zhuyinbo@...ngson.cn>
>> +
>> +properties:
>> +  compatible:
>> +    const: loongson,ls2k-thermal
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  "#thermal-sensor-cells":
> 
> Use same quotes in all places - either ' or "
Thanks for reminding me, I will fix it.
> 
>> +    const: 1> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - '#thermal-sensor-cells'
> 
> With quotes fixed:
I will use "'" uniformly.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof
>