linux-kernel - Re: [PATCH linux-next v2] backlight: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2022 09:27:08 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     yexingchen116@...il.com
Cc:     jingoohan1@...il.com, lee@...nel.org, deller@....de,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ye xingchen <ye.xingchen@....com.cn>
Subject: Re: [PATCH linux-next v2] backlight: use sysfs_emit() to instead of
 scnprintf()

On Wed, Sep 28, 2022 at 01:41:15AM +0000, yexingchen116@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
>
> Replace the open-code with sysfs_emit() to simplify the code.
>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
> v1 -> v2
> Add the rest of this fixes for this pattern in the 'drivers/video/backlight' directory.
>  drivers/video/backlight/lm3533_bl.c | 10 +++++-----
>  drivers/video/backlight/lp855x_bl.c |  4 ++--

What happened to the lp8788 fixes?


Daniel.


>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm3533_bl.c
> index 1df1b6643c0b..5e2ce9285245 100644
> --- a/drivers/video/backlight/lm3533_bl.c
> +++ b/drivers/video/backlight/lm3533_bl.c
> @@ -66,7 +66,7 @@ static ssize_t show_id(struct device *dev,
>  {
>  	struct lm3533_bl *bl = dev_get_drvdata(dev);
>
> -	return scnprintf(buf, PAGE_SIZE, "%d\n", bl->id);
> +	return sysfs_emit(buf, "%d\n", bl->id);
>  }
>
>  static ssize_t show_als_channel(struct device *dev,
> @@ -75,7 +75,7 @@ static ssize_t show_als_channel(struct device *dev,
>  	struct lm3533_bl *bl = dev_get_drvdata(dev);
>  	unsigned channel = lm3533_bl_get_ctrlbank_id(bl);
>
> -	return scnprintf(buf, PAGE_SIZE, "%u\n", channel);
> +	return sysfs_emit(buf, "%u\n", channel);
>  }
>
>  static ssize_t show_als_en(struct device *dev,
> @@ -95,7 +95,7 @@ static ssize_t show_als_en(struct device *dev,
>  	mask = 1 << (2 * ctrlbank);
>  	enable = val & mask;
>
> -	return scnprintf(buf, PAGE_SIZE, "%d\n", enable);
> +	return sysfs_emit(buf, "%d\n", enable);
>  }
>
>  static ssize_t store_als_en(struct device *dev,
> @@ -147,7 +147,7 @@ static ssize_t show_linear(struct device *dev,
>  	else
>  		linear = 0;
>
> -	return scnprintf(buf, PAGE_SIZE, "%x\n", linear);
> +	return sysfs_emit(buf, "%x\n", linear);
>  }
>
>  static ssize_t store_linear(struct device *dev,
> @@ -190,7 +190,7 @@ static ssize_t show_pwm(struct device *dev,
>  	if (ret)
>  		return ret;
>
> -	return scnprintf(buf, PAGE_SIZE, "%u\n", val);
> +	return sysfs_emit(buf, "%u\n", val);
>  }
>
>  static ssize_t store_pwm(struct device *dev,
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index bd0bdeae23a4..fafc1a9e76ef 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -293,7 +293,7 @@ static ssize_t lp855x_get_chip_id(struct device *dev,
>  {
>  	struct lp855x *lp = dev_get_drvdata(dev);
>
> -	return scnprintf(buf, PAGE_SIZE, "%s\n", lp->chipname);
> +	return sysfs_emit(buf, "%s\n", lp->chipname);
>  }
>
>  static ssize_t lp855x_get_bl_ctl_mode(struct device *dev,
> @@ -307,7 +307,7 @@ static ssize_t lp855x_get_bl_ctl_mode(struct device *dev,
>  	else if (lp->mode == REGISTER_BASED)
>  		strmode = "register based";
>
> -	return scnprintf(buf, PAGE_SIZE, "%s\n", strmode);
> +	return sysfs_emit(buf, "%s\n", strmode);
>  }
>
>  static DEVICE_ATTR(chip_id, S_IRUGO, lp855x_get_chip_id, NULL);
> --
> 2.25.1
>
>