linux-kernel - Re: [PATCH RFC SPI for-next 2/2] spi: microchip: pci1xxxx: Add suspend and resume support for PCI1XXXX SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzQwQwL4NOTMMe18@sirena.org.uk>
Date:   Wed, 28 Sep 2022 12:30:11 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Tharun Kumar P <tharunkumar.pasumarthi@...rochip.com>
Cc:     linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH RFC SPI for-next 2/2] spi: microchip: pci1xxxx: Add
 suspend and resume support for PCI1XXXX SPI driver

On Wed, Sep 28, 2022 at 09:13:36AM +0530, Tharun Kumar P wrote:

> +	for (iter = 0; iter < spi_ptr->total_hw_instances; iter++) {
> +		spi_sub_ptr = spi_ptr->spi_int[iter];
> +
> +		/* Store existing config before suspend */
> +		store_restore_config(spi_ptr, spi_sub_ptr, iter, 1);
> +		spi_master_suspend(spi_sub_ptr->spi_host);
> +		writel(reg1, spi_ptr->reg_base +
> +		       SPI_MST_EVENT_MASK_REG_OFFSET(iter));
> +	}

This saves the register configuration before suspending the device,
meaning there may be in progress transfers changing the device while the
save is going on.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)