linux-kernel - Re: [PATCH RFC SPI for-next 1/2] spi: microchip: pci1xxxx: Add driver for SPI controller of PCI1XXXX PCIe switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5febd5014483d49b445a16853a2ead3e973265e0.camel@microchip.com>
Date:   Fri, 30 Sep 2022 05:51:51 +0000
From:   <Tharunkumar.Pasumarthi@...rochip.com>
To:     <broonie@...nel.org>
CC:     <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH RFC SPI for-next 1/2] spi: microchip: pci1xxxx: Add driver
 for SPI controller of PCI1XXXX PCIe switch

On Wed, 2022-09-28 at 12:26 +0100, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Please make the above a single C++ style comment block so things look more 
> intentional.

Okay.

> This does nothing if the chip select is to be disabled, that's clearly not
> going to work. 

Okay. I will handle disable case of chip select.

> The driver should set SPI_CONTROLLER_TX since it needs to transmit data inorer
> to receive

Okay.

> Please write normal conditional statements to improve legibility.

Okay.

> Are you sure the device is fully set up and ready for interrupts at this 
> point, and that the freeing of the driver will work fine with devm?

Okay, I will move init_completion and interrupt mask management before
devm_request_irq API. 


Thanks,
Tharun Kumar P