linux-kernel - [PATCH -next] tty: serial: atmel: driver depends on COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220929054851.7723-1-rdunlap@infradead.org>
Date:   Wed, 28 Sep 2022 22:48:51 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Sergiu Moga <sergiu.moga@...rochip.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Richard Genoud <richard.genoud@...il.com>,
        linux-serial@...r.kernel.org, Jiri Slaby <jirislaby@...nel.org>
Subject: [PATCH -next] tty: serial: atmel: driver depends on COMMON_CLK

Since atmel_serial.c uses interfaces that are provided by
the COMMON_CLK Kconfig symbol, the driver should depend on
COMMON_CLK to prevent build errors.

ld: drivers/tty/serial/atmel_serial.o: in function `atmel_serial_pm':
atmel_serial.c:(.text+0x1553): undefined reference to `__clk_is_enabled'
ld: drivers/tty/serial/atmel_serial.o: in function `atmel_set_termios':
atmel_serial.c:(.text+0x1dfe): undefined reference to `__clk_is_enabled'

Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Sergiu Moga <sergiu.moga@...rochip.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Richard Genoud <richard.genoud@...il.com>
Cc: linux-serial@...r.kernel.org
Cc: Jiri Slaby <jirislaby@...nel.org>
---
 drivers/tty/serial/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -128,6 +128,7 @@ config SERIAL_SB1250_DUART_CONSOLE
 config SERIAL_ATMEL
 	bool "AT91 on-chip serial port support"
 	depends on ARCH_AT91 || COMPILE_TEST
+	depends on COMMON_CLK
 	select SERIAL_CORE
 	select SERIAL_MCTRL_GPIO if GPIOLIB
 	select MFD_AT91_USART