linux-kernel - Re: [PATCH -next] tty: serial: atmel: driver depends on COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ceefc4c1-128b-6582-6074-378ad3ae7e0a@gmail.com>
Date:   Thu, 29 Sep 2022 09:35:18 +0200
From:   Richard Genoud <richard.genoud@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Sergiu Moga <sergiu.moga@...rochip.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, Jiri Slaby <jirislaby@...nel.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>
Subject: Re: [PATCH -next] tty: serial: atmel: driver depends on COMMON_CLK

Hi,
Le 29/09/2022 à 07:48, Randy Dunlap a écrit :
> Since atmel_serial.c uses interfaces that are provided by
> the COMMON_CLK Kconfig symbol, the driver should depend on
> COMMON_CLK to prevent build errors.
> 
> ld: drivers/tty/serial/atmel_serial.o: in function `atmel_serial_pm':
> atmel_serial.c:(.text+0x1553): undefined reference to `__clk_is_enabled'
> ld: drivers/tty/serial/atmel_serial.o: in function `atmel_set_termios':
> atmel_serial.c:(.text+0x1dfe): undefined reference to `__clk_is_enabled'
> 
> Fixes: 5e3ce1f26129 ("tty: serial: atmel: Make the driver aware of the existence of GCLK")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Sergiu Moga <sergiu.moga@...rochip.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Richard Genoud <richard.genoud@...il.com>
> Cc: linux-serial@...r.kernel.org
> Cc: Jiri Slaby <jirislaby@...nel.org>

There's already a patch fixing this, acked by Nicolas :
https://lkml.org/lkml/2022/9/26/1587

> ---
>   drivers/tty/serial/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -128,6 +128,7 @@ config SERIAL_SB1250_DUART_CONSOLE
>   config SERIAL_ATMEL
>   	bool "AT91 on-chip serial port support"
>   	depends on ARCH_AT91 || COMPILE_TEST
> +	depends on COMMON_CLK
>   	select SERIAL_CORE
>   	select SERIAL_MCTRL_GPIO if GPIOLIB
>   	select MFD_AT91_USART

Thanks !

Regards,
Richard