linux-kernel - Re: [RFC PATCH v3 1/3] softirq: Add generic accessor to percpu softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzVt0FVDPIPfsQ5t@osiris>
Date:   Thu, 29 Sep 2022 12:05:04 +0200
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     John Stultz <jstultz@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        John Dias <joaodias@...gle.com>,
        "Connor O'Brien" <connoro@...gle.com>,
        Rick Yiu <rickyiu@...gle.com>, John Kacur <jkacur@...hat.com>,
        Qais Yousef <qais.yousef@....com>,
        Chris Redpath <chris.redpath@....com>,
        Abhijeet Dharmapurikar <adharmap@...cinc.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vasily Gorbik <gor@...ux.ibm.com>, kernel-team@...roid.com,
        kernel test robot <lkp@...el.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>
Subject: Re: [RFC PATCH v3 1/3] softirq: Add generic accessor to percpu
 softirq_pending data

On Wed, Sep 21, 2022 at 01:25:48AM +0000, John Stultz wrote:
> In a previous iteration of this patch series, I was checking:
> 
>    per_cpu(irq_stat, cpu).__softirq_pending
> 
> which resulted in build errors on s390.
> 
> This patch tries to create a generic accessor to this percpu
> softirq_pending data.
> 
> This interface is inherently racy as its reading percpu data
> without a lock. However, being able to peek at the softirq
> pending data allows us to make better decisions about rt task
> placement vs just ignoring it.
> 
> On s390 this call returns 0, which maybe isn't ideal but
> results in no functional change from what we do now.
> 
> Feedback or suggestions for better approach here would be
> welcome!
...
> diff --git a/arch/s390/include/asm/hardirq.h b/arch/s390/include/asm/hardirq.h
> index 58668ffb5488..cd9cc11588ab 100644
> --- a/arch/s390/include/asm/hardirq.h
> +++ b/arch/s390/include/asm/hardirq.h
> @@ -16,6 +16,12 @@
>  #define local_softirq_pending() (S390_lowcore.softirq_pending)
>  #define set_softirq_pending(x) (S390_lowcore.softirq_pending = (x))
>  #define or_softirq_pending(x)  (S390_lowcore.softirq_pending |= (x))
> +/*
> + *  Not sure what the right thing is here  for s390,
> + *  but returning 0 will result in no logical change
> + *  from what happens now
> + */
> +#define __cpu_softirq_pending(x) (0)

Hm, yes. This would require some ugly code to make this work properly,
plus might cause unique problems on s390 if the cpu in question is
offline.
So I'd say we might change s390 to use a proper per cpu irqstat
variable instead, if this new interface is being agreed on.