linux-kernel - Re: [PATCH net-next] can: j1939: j1939_session_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220930065720.GC6082@pengutronix.de>
Date:   Fri, 30 Sep 2022 08:57:20 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>
Cc:     Robin van der Gracht <robin@...tonic.nl>,
        Oleksij Rempel <linux@...pel-privat.de>, kernel@...gutronix.de,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] can: j1939: j1939_session_tx_eoma(): fix debug
 info

On Fri, Sep 30, 2022 at 02:52:08PM +0800, Zhang Changzhong wrote:
> Use "%s" instead of "%p" to print function name in debug info.
> 
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Acked-by: Oleksij Rempel <o.rempel@...gutronix.de>

Thank you!

> ---
>  net/can/j1939/transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/can/j1939/transport.c b/net/can/j1939/transport.c
> index d7d86c9..6ec48a4 100644
> --- a/net/can/j1939/transport.c
> +++ b/net/can/j1939/transport.c
> @@ -985,7 +985,7 @@ static int j1939_session_tx_eoma(struct j1939_session *session)
>  	/* wait for the EOMA packet to come in */
>  	j1939_tp_set_rxtimeout(session, 1250);
>  
> -	netdev_dbg(session->priv->ndev, "%p: 0x%p\n", __func__, session);
> +	netdev_dbg(session->priv->ndev, "%s: 0x%p\n", __func__, session);
>  
>  	return 0;
>  }
> -- 
> 2.9.5
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |