linux-kernel - Re: [PATCH V14 1/7] dt-bindings: Added the yaml bindings for DCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78b42aab-164a-7fe6-fec5-77f52199c641@quicinc.com>
Date:   Fri, 30 Sep 2022 12:29:00 +0530
From:   Souradeep Chowdhury <quic_schowdhu@...cinc.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, Alex Elder <elder@...e.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        "Sai Prakash Ranjan" <quic_saipraka@...cinc.com>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        Rajendra Nayak <quic_rjendra@...cinc.com>, <vkoul@...nel.org>
Subject: Re: [PATCH V14 1/7] dt-bindings: Added the yaml bindings for DCC


On 9/28/2022 11:00 PM, Krzysztof Kozlowski wrote:
> On 28/09/2022 19:11, Souradeep Chowdhury wrote:
>> Documentation for Data Capture and Compare(DCC) device tree bindings
>> in yaml format.
>>
>> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> Reviewed-by: Bjorn Andersson <andersson@...nel.org>
> I asked last time and there was just partial improvement, so let me be
> clear: you must rebase on latest kernel and use scripts/get_maintainers.pl.
>
> I am repeating myself, which should not be actually needed... but then
> maybe my comment was not accurate? If so, please post the output of `git
> describe` and `scripts/get_maintainers.pl __on_your_patches__` and let's
> go line by line...

Apologies for the incomplete list.

I had re-based this patch on top of "for-next" branch of the kernel 
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git.

My git describe shows something like as follows

qcom-arm64-for-6.1-173-gd92bd73

Also the ./script/maintainers.pl gives the below output

Souradeep Chowdhury <quic_schowdhu@...cinc.com> (maintainer:DCC QTI 
DRIVER,in file)
Andy Gross <agross@...nel.org> (maintainer:ARM/QUALCOMM SUPPORT)
Bjorn Andersson <andersson@...nel.org> (maintainer:ARM/QUALCOMM SUPPORT)
Konrad Dybcio <konrad.dybcio@...ainline.org> (reviewer:ARM/QUALCOMM SUPPORT)
Rob Herring <robh+dt@...nel.org> (maintainer:OPEN FIRMWARE AND FLATTENED 
DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org> (maintainer:OPEN 
FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-arm-msm@...r.kernel.org (open list:DCC QTI DRIVER)
devicetree@...r.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE 
TREE BINDINGS)
linux-kernel@...r.kernel.org (open list)

Will send out the next version accordingly, let me know in case of any 
further concerns.

>
>
>> ---
>>   .../devicetree/bindings/soc/qcom/qcom,dcc.yaml     | 44 ++++++++++++++++++++++
>>   1 file changed, 44 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml
>> new file mode 100644
>> index 0000000..8396b0c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,dcc.yaml
>> @@ -0,0 +1,44 @@
>> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Data Capture and Compare
>> +
>> +maintainers:
>> +  - Souradeep Chowdhury <quic_schowdhu@...cinc.com>
>> +
>> +description: |
>> +    DCC (Data Capture and Compare) is a DMA engine which is used to save
>> +    configuration data or system memory contents during catastrophic failure
>> +    or SW trigger. DCC is used to capture and store data for debugging purpose
>> +
>> +properties:
>> +  compatible:
>> +    items:
>> +      - enum:
>> +          - qcom,sm8150-dcc
>> +          - qcom,sc7280-dcc
>> +          - qcom,sc7180-dcc
>> +          - qcom,sdm845-dcc
>> +      - const: qcom,dcc
>> +
>> +  reg:
>> +    items:
>> +      - description: DCC base register region
>> +      - description: DCC RAM base register region
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    dma@...2000{
>> +                compatible = "qcom,sm8150-dcc","qcom,dcc";
> odd indentation. Use 4 spaces for example indentation.
Ack
>
>> +                reg = <0x010a2000 0x1000>,
>> +                      <0x010ad000 0x2000>;
>> +    };
> Best regards,
> Krzysztof
>