linux-kernel - Re: [PATCH] livepatch: Move the result-invariant calculation out of the loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzacvcSOoICzYtx8@alley>
Date:   Fri, 30 Sep 2022 09:37:33 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Josh Poimboeuf <jpoimboe@...nel.org>,
        Jiri Kosina <jikos@...nel.org>,
        Miroslav Benes <mbenes@...e.cz>,
        Joe Lawrence <joe.lawrence@...hat.com>,
        live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] livepatch: Move the result-invariant calculation out of
 the loop

On Fri 2022-09-30 09:54:46, Zhen Lei wrote:
> The calculation results of the variables 'func_addr' and 'func_size' are
> not affected by the for loop and do not change due to the changes of
> entries[i]. The performance can be improved by moving it outside the loop.
> 
> No functional change.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Makes sense:

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr