linux-kernel - Re: [PATCH] livepatch: Move the result-invariant calculation out of the loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2210181551140.29912@cbobk.fhfr.pm>
Date:   Tue, 18 Oct 2022 15:51:36 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Petr Mladek <pmladek@...e.com>
cc:     Zhen Lei <thunder.leizhen@...wei.com>,
        Josh Poimboeuf <jpoimboe@...nel.org>,
        Miroslav Benes <mbenes@...e.cz>,
        Joe Lawrence <joe.lawrence@...hat.com>,
        live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] livepatch: Move the result-invariant calculation out of
 the loop

On Fri, 30 Sep 2022, Petr Mladek wrote:

> > The calculation results of the variables 'func_addr' and 'func_size' are
> > not affected by the for loop and do not change due to the changes of
> > entries[i]. The performance can be improved by moving it outside the loop.
> > 
> > No functional change.
> > 
> > Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> 
> Makes sense:
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>

Seems like this wasn't picked up by anybody, so I have now pushed it to 
livepatching.git#for-6.2/core

Thanks,

-- 
Jiri Kosina
SUSE Labs