linux-kernel - Re: [PATCH] sound:remove unnecessary conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k05l6zkp.wl-tiwai@suse.de>
Date:   Fri, 30 Sep 2022 10:23:02 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     shijm <junming@...china.com>
Cc:     Linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound:remove unnecessary conversions

On Fri, 30 Sep 2022 04:52:44 +0200,
shijm wrote:
> 
> From: Shi junming <junming@...china.com>
> 
> remove unnecessary conversions
> 
> Signed-off-by: Shi junming <junming@...china.com>

The code changes themselves are fine, but this patch has more room for
(trivial) improvements.

First off, it won't hurt if you give more text in the patch
description.  Only from this one line text, it's not entirely clear
what the patch is doing and how.

In this case, it might be better understandable to use a term "cast"
(or "type cast") instead of "conversion", too.  And, a sentence should
start with a capital letter.

The subject line for sound subsystem should be with "ALSA:" prefix,
and in this case, "ALSA: pcm: xxx" would be more suitable (the subject
prefix depends on the system, see other git logs).

Last but not least, at the next submission, please put the
corresponding subsystem mailing list (alsa-devel ML) to Cc, too.

thanks,

Takashi

> ---
>  include/sound/pcm.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/sound/pcm.h b/include/sound/pcm.h
> index 6b99310b5b88..0530cfa08892 100644
> --- a/include/sound/pcm.h
> +++ b/include/sound/pcm.h
> @@ -1344,7 +1344,7 @@ snd_pcm_sgbuf_get_chunk_size(struct snd_pcm_substream *substream,
>   */
>  static inline void snd_pcm_mmap_data_open(struct vm_area_struct *area)
>  {
> -	struct snd_pcm_substream *substream = (struct snd_pcm_substream *)area->vm_private_data;
> +	struct snd_pcm_substream *substream = area->vm_private_data;
>  	atomic_inc(&substream->mmap_count);
>  }
>  
> @@ -1356,7 +1356,7 @@ static inline void snd_pcm_mmap_data_open(struct vm_area_struct *area)
>   */
>  static inline void snd_pcm_mmap_data_close(struct vm_area_struct *area)
>  {
> -	struct snd_pcm_substream *substream = (struct snd_pcm_substream *)area->vm_private_data;
> +	struct snd_pcm_substream *substream = area->vm_private_data;
>  	atomic_dec(&substream->mmap_count);
>  }
>  
> -- 
> 2.18.2
>