linux-kernel - Re: [PATCH for-next] RDMA: return -EOPNOSUPP for ODP unsupported device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=hENegJLuWZUvCVk66MFUE_m64PbqY7+mG2jZz3+Wyu4i6+w@mail.gmail.com>
Date:   Sat, 1 Oct 2022 18:50:47 +0800
From:   Zhu Yanjun <zyjzyj2000@...il.com>
To:     Li Zhijian <lizhijian@...itsu.com>
Cc:     Bob Pearson <rpearsonhpe@...il.com>,
        Leon Romanovsky <leon@...nel.org>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-next] RDMA: return -EOPNOSUPP for ODP unsupported device

On Sat, Oct 1, 2022 at 10:00 AM Li Zhijian <lizhijian@...itsu.com> wrote:
>
> ib_reg_mr(3) which is used to register a MR with specific access flags
> for specific HCA will set errno when something go wrong.
> So, here we should return the specific -EOPNOTSUPP when the being
> requested ODP access flag is unspported by the HCA(such as RXE).
>
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>

Reviewed-by: Zhu Yanjun <zyjzyj2000@...il.com>

Thanks.
Zhu Yanjun
> ---
>  include/rdma/ib_verbs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index 975d6e9efbcb..a1f4d53a4bb6 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -4334,7 +4334,7 @@ static inline int ib_check_mr_access(struct ib_device *ib_dev,
>
>         if (flags & IB_ACCESS_ON_DEMAND &&
>             !(ib_dev->attrs.kernel_cap_flags & IBK_ON_DEMAND_PAGING))
> -               return -EINVAL;
> +               return -EOPNOTSUPP;
>         return 0;
>  }
>
> --
> 2.31.1
>