linux-kernel - Re: [PATCH] Improve comment of get_random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzglFDjXE2oN6QzH@zx2c4.com>
Date:   Sat, 1 Oct 2022 13:31:32 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     William Zijl <postmaster@...ted.xyz>
Cc:     tytso@....edu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Improve comment of get_random_bytes function

On Sat, Oct 01, 2022 at 02:18:31AM +0200, William Zijl wrote:
> The old comment of this function had a double whitespace and contained
> grammatical errors, such as: `the randomness by this function`, `at
> least once at any point prior`. This patch replaces those sentenced with
> `the randomness of this function`, `at any point prior to this`
> respectively.

"at any point prior" seems fine to me.

"the randomness by this function" is wrong, but the correction for it
should be "the randomness returned by this function".

Feel free to submit a v2.

Jason