| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 1 Oct 2022 20:59:50 +0800
From: kernel test robot <lkp@...el.com>
To: chengwei <foxfly.lai.tw@...il.com>, pavel@....cz, lee@...nel.org
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org, GaryWang@...on.com.tw,
musa.lin@...jingtech.com, jack.chang@...jingtech.com,
chengwei <larry.lai@...jingtech.com>,
Javier Arteaga <javier@...tex.com>,
Nicola Lunghi <nicola.lunghi@...tex.com>
Subject: Re: [PATCH] mfd: Add support for UP board CPLD/FPGA
Hi chengwei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pavel-leds/for-next]
[also build test ERROR on lee-mfd/for-mfd-next linus/master v6.0-rc7 next-20220930]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/chengwei/mfd-Add-support-for-UP-board-CPLD-FPGA/20221001-170758
base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
config: sh-allmodconfig
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6d967fb7e06c0b284bf19de7680621c4d78348eb
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review chengwei/mfd-Add-support-for-UP-board-CPLD-FPGA/20221001-170758
git checkout 6d967fb7e06c0b284bf19de7680621c4d78348eb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/mfd/upboard-fpga.c: In function 'upboard_fpga_probe':
>> drivers/mfd/upboard-fpga.c:394:18: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration]
394 | status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv);
| ^~~~~~~~~~~~~~~~~~~~~
| acpi_evaluate_object
cc1: some warnings being treated as errors
vim +394 drivers/mfd/upboard-fpga.c
376
377 static int __init upboard_fpga_probe(struct platform_device *pdev)
378 {
379 struct upboard_fpga *fpga;
380 const struct acpi_device_id *id;
381 const struct upboard_fpga_data *fpga_data;
382 const struct dmi_system_id *system_id;
383 acpi_handle handle;
384 acpi_status status;
385 unsigned long long hrv;
386 unsigned long quirks = 0;
387 int ret;
388
389 id = acpi_match_device(upboard_fpga_acpi_match, &pdev->dev);
390 if (!id)
391 return -ENODEV;
392
393 handle = ACPI_HANDLE(&pdev->dev);
> 394 status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv);
395 if (ACPI_FAILURE(status)) {
396 dev_err(&pdev->dev, "failed to get PCTL revision");
397 return -ENODEV;
398 }
399
400 system_id = dmi_first_match(upboard_dmi_table);
401 if (system_id)
402 quirks = (unsigned long)system_id->driver_data;
403
404 if (hrv == 1 && (quirks & UPFPGA_QUIRK_HRV1_IS_PROTO2))
405 hrv = UPFPGA_PROTOCOL_V2_HRV;
406
407 if (hrv != UPFPGA_PROTOCOL_V2_HRV) {
408 dev_dbg(&pdev->dev, "unsupported PCTL revision: %llu", hrv);
409 return -ENODEV;
410 }
411
412 fpga_data = (const struct upboard_fpga_data *) id->driver_data;
413
414 fpga = devm_kzalloc(&pdev->dev, sizeof(*fpga), GFP_KERNEL);
415 if (!fpga)
416 return -ENOMEM;
417
418 if (quirks & UPFPGA_QUIRK_UNINITIALISED) {
419 dev_info(&pdev->dev, "FPGA not initialised by this BIOS");
420 fpga->uninitialised = true;
421 }
422
423 dev_set_drvdata(&pdev->dev, fpga);
424 fpga->dev = &pdev->dev;
425 fpga->regmap = devm_regmap_init(&pdev->dev, NULL, fpga,
426 fpga_data->regmapconf);
427 if (IS_ERR(fpga->regmap))
428 return PTR_ERR(fpga->regmap);
429
430 ret = upboard_fpga_gpio_init(fpga);
431 if (ret) {
432 dev_err(&pdev->dev, "failed to init FPGA comm GPIOs: %d", ret);
433 return ret;
434 }
435
436 ret = upboard_fpga_detect_firmware(fpga);
437 if (ret)
438 return ret;
439
440 if (quirks & UPFPGA_QUIRK_GPIO_LED) {
441 #define APL_GPIO_218 507
442 static struct gpio_led upboard_gpio_leds[] = {
443 {
444 .name = "upboard:blue:",
445 .gpio = APL_GPIO_218,
446 .default_state = LEDS_GPIO_DEFSTATE_KEEP,
447 },
448 };
449 static struct gpio_led_platform_data upboard_gpio_led_platform_data = {
450 .num_leds = ARRAY_SIZE(upboard_gpio_leds),
451 .leds = upboard_gpio_leds,
452 };
453 static const struct mfd_cell upboard_gpio_led_cells[] = {
454 {
455 .name = "leds-gpio",
456 .id = 0,
457 .platform_data = &upboard_gpio_led_platform_data,
458 .pdata_size = sizeof(upboard_gpio_led_platform_data),
459 },
460 };
461
462 ret = devm_mfd_add_devices(&pdev->dev, 0, upboard_gpio_led_cells,
463 ARRAY_SIZE(upboard_gpio_led_cells), NULL, 0, NULL);
464 if (ret) {
465 dev_err(&pdev->dev, "Failed to add GPIO leds");
466 return ret;
467 }
468
469 }
470
471 return devm_mfd_add_devices(&pdev->dev, 0, fpga_data->cells,
472 fpga_data->ncells, NULL, 0, NULL);
473 }
474
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (241855 bytes)
Powered by blists - more mailing lists