linux-kernel - Re: [PATCH] mfd: Add support for UP board CPLD/FPGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzqRvsfsREslOuW2@google.com>
Date:   Mon, 3 Oct 2022 08:39:42 +0100
From:   Lee Jones <lee@...nel.org>
To:     chengwei <foxfly.lai.tw@...il.com>
Cc:     pavel@....cz, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org, GaryWang@...on.com.tw,
        musa.lin@...jingtech.com, jack.chang@...jingtech.com,
        chengwei <larry.lai@...jingtech.com>,
        Javier Arteaga <javier@...tex.com>,
        Nicola Lunghi <nicola.lunghi@...tex.com>
Subject: Re: [PATCH] mfd: Add support for UP board CPLD/FPGA

On Sat, 01 Oct 2022, chengwei wrote:

> The UP Squared board <http://www.upboard.com> implements certain
> features (pin control, onboard LEDs or CEC) through an on-board FPGA.
> 
> This mfd driver implements the line protocol to read and write registers
> from the FPGA through regmap. The register address map is also included.
> 
> The UP boards come with a few FPGA-controlled onboard LEDs:
> * UP Board: yellow, green, red
> * UP Squared: blue, yellow, green, red
> 
> The UP Boards provide a few I/O pin headers (for both GPIO and
> functions), including a 40-pin Raspberry Pi compatible header.
> 
> This patch implements support for the FPGA-based pin controller that
> manages direction and enable state for those header pins.
> 
> Partial support UP boards:
> * UP core + CREX
> * UP core + CRST02
> 
> Signed-off-by: Javier Arteaga <javier@...tex.com>
> [merge various fixes]
> Signed-off-by: Nicola Lunghi <nicola.lunghi@...tex.com>
> Signed-off-by: chengwei <larry.lai@...jingtech.com>
> ---
>  drivers/leds/Kconfig             |  10 +
>  drivers/leds/Makefile            |   1 +
>  drivers/leds/leds-upboard.c      |  90 ++++++
>  drivers/mfd/Kconfig              |   9 +
>  drivers/mfd/Makefile             |   1 +
>  drivers/mfd/upboard-fpga.c       | 486 +++++++++++++++++++++++++++++++
>  include/linux/mfd/upboard-fpga.h |  53 ++++

Please separate the LED and MFD changes into their own patches.

>  7 files changed, 650 insertions(+)
>  create mode 100644 drivers/leds/leds-upboard.c
>  create mode 100644 drivers/mfd/upboard-fpga.c
>  create mode 100644 include/linux/mfd/upboard-fpga.h

-- 
Lee Jones [李琼斯]