linux-kernel - Re: [PATCH v3] Documentation/process: Add text to indicate supporters should be mailed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Oct 2022 08:04:07 +0900
From:   Akira Yokosawa <akiyks@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     corbet@....net, konstantin@...uxfoundation.org,
        Theodore Ts'o <tytso@....edu>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux@...mhuis.info, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Akira Yokosawa <akiyks@...il.com>
Subject: Re: [PATCH v3] Documentation/process: Add text to indicate supporters
 should be mailed

Hello Joe,

Thank you for chiming in.

On 2022/10/03 0:49, Joe Perches wrote:
> On Sun, 2022-10-02 at 09:58 +0200, Krzysztof Kozlowski wrote:
>> The easiest to achieve it is to run with --no-git-fallback and CC entire
>> output. However it does not mean submitter must run with
>> --no-git-fallback. It is only for this generic rule - CC entire output
>> of get_maintainers.pl.
>>
>> If you add such rule "CC entire output of get_maintainers.pl" and do not
>> mention no-git-fallback, some folks will think they need to CC all these
>> people who made one commit to your file...
> 
> false.
> 
> git-fallback is _not_ used when there is a listed maintainer for a
> specific file.
> 
> If there is a use of git-fallback, it's because there is _no_
> specified maintainer for a specific file.
> 
>    --git-fallback => use git when no exact MAINTAINERS pattern (default: 1)
> 
> i.e.: It's not "your file" if you don't maintain it.

Joe, I sometimes see unexpected output WRT --git-fallback.

Example:

    $ ./get_maintainer.pl -f Documentation/doc-guide/sphinx.rst
    Jonathan Corbet <corbet@....net> (maintainer:DOCUMENTATION,commit_signer:1/1=100%)
  <-- ???
    Lukas Bulwahn <lukas.bulwahn@...il.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,removed_lines:2/2=100%)
    <-- ???
    linux-doc@...r.kernel.org (open list:DOCUMENTATION)

    linux-kernel@...r.kernel.org (open list)

As you see, --git-fallback is used in this case. Why?
It looks strange to me as Jon is listed as a "maintainer".

Having "F:	Documentation/" in MAINTAINERS does not suffice?

Can you elaborate?

Regards,
Akira