linux-kernel - Re: [PATCH] HID: alps: Simplify the .remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzsCdyPxrNcHE3XF@gmail.com>
Date:   Mon, 3 Oct 2022 17:40:39 +0200
From:   Marcus Folkesson <marcus.folkesson@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: alps: Simplify the .remove function

Hi Christophe!

On Sun, Oct 02, 2022 at 04:38:26PM +0200, Christophe JAILLET wrote:
> If the .remove function of a 'hid_driver' is NULL, the default behavior is
> to call hid_hw_stop().
> 
> So alps_remove() can be removed here, it is just hand-writing what
> already exists.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---


There is already a patch out there :-)

https://lore.kernel.org/all/20220915123438.520775-1-marcus.folkesson@gmail.com/

Best regards,
Marcus Folkesson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)