linux-kernel - Re: [PATCH] HID: alps: Simplify the .remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6c0cda1-b30d-5ca9-54e5-0643f7d5ffd9@wanadoo.fr>
Date:   Mon, 3 Oct 2022 21:16:55 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Marcus Folkesson <marcus.folkesson@...il.com>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: alps: Simplify the .remove function

Le 03/10/2022 à 17:40, Marcus Folkesson a écrit :
> Hi Christophe!
> 
> On Sun, Oct 02, 2022 at 04:38:26PM +0200, Christophe JAILLET wrote:
>> If the .remove function of a 'hid_driver' is NULL, the default behavior is
>> to call hid_hw_stop().
>>
>> So alps_remove() can be removed here, it is just hand-writing what
>> already exists.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>> ---
> 
> 
> There is already a patch out there :-)

Great,

But I always find it funny when something that is there since many years 
(819d64e51d62 - 2016-06-23) is fixed twice in a row from unrelated work!

CJ

> 
> https://lore.kernel.org/all/20220915123438.520775-1-marcus.folkesson@gmail.com/
> 
> Best regards,
> Marcus Folkesson