lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Oct 2022 20:37:46 +0100 From: "Colin King (gmail)" <colin.i.king@...il.com> To: Frank Li <Frank.Li@....com>, Marc Zyngier <maz@...nel.org> Cc: Thomas Gleixner <tglx@...utronix.de>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, NXP Linux Team <linux-imx@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: re: irqchip: Add IMX MU MSI controller driver Hi, Static analysis with clang scan-build detected an issue with the following commit in linux-next: commit 70afdab904d2d1e68bffe75fe08e7e48e0b0ff8e Author: Frank Li <Frank.Li@....com> Date: Thu Sep 22 11:12:43 2022 -0500 irqchip: Add IMX MU MSI controller driver The issue is as follows in source drivers/irqchip/irq-imx-mu-msi.c : static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = { .type = IMX_MU_V2, .xTR = 0x200, .xRR = 0x280, .xSR = { [IMX_MU_SR] = 0xC, [IMX_MU_GSR] = 0x118, [IMX_MU_GSR] = 0x124, /* <--- issue here */ [IMX_MU_RSR] = 0x12C, }, .xCR = { [IMX_MU_GIER] = 0x110, [IMX_MU_GCR] = 0x114, [IMX_MU_TCR] = 0x120, [IMX_MU_RCR] = 0x128 }, }; The .xSR object with index IMX_MU_GSR is being set twice, once with 0x118 and again with 0x128. I believe the first one should be IMX_MU_TSR but w/o the datasheet I don't want to make any assumptions. Colin
Powered by blists - more mailing lists