linux-kernel - RE: [EXT] Re: irqchip: Add IMX MU MSI controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM9PR04MB879381782BA8387D90E75EB6885A9@AM9PR04MB8793.eurprd04.prod.outlook.com>
Date:   Tue, 4 Oct 2022 19:49:19 +0000
From:   Frank Li <frank.li@....com>
To:     Marc Zyngier <maz@...nel.org>,
        "Colin King (gmail)" <colin.i.king@...il.com>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: irqchip: Add IMX MU MSI controller driver



> -----Original Message-----
> From: Marc Zyngier <maz@...nel.org>
> Sent: Tuesday, October 4, 2022 2:44 PM
> To: Colin King (gmail) <colin.i.king@...il.com>; Frank Li <frank.li@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>; Shawn Guo
> <shawnguo@...nel.org>; Sascha Hauer <s.hauer@...gutronix.de>;
> Pengutronix Kernel Team <kernel@...gutronix.de>; Fabio Estevam
> <festevam@...il.com>; dl-linux-imx <linux-imx@....com>; linux-
> kernel@...r.kernel.org
> Subject: [EXT] Re: irqchip: Add IMX MU MSI controller driver
> 
> Caution: EXT Email
> 
> On Tue, 04 Oct 2022 20:37:46 +0100,
> "Colin King (gmail)" <colin.i.king@...il.com> wrote:
> >
> > Hi,
> >
> > Static analysis with clang scan-build detected an issue with the
> > following commit in linux-next:
> >
> > commit 70afdab904d2d1e68bffe75fe08e7e48e0b0ff8e
> > Author: Frank Li <Frank.Li@....com>
> > Date:   Thu Sep 22 11:12:43 2022 -0500
> >
> >     irqchip: Add IMX MU MSI controller driver
> >
> > The issue is as follows in source drivers/irqchip/irq-imx-mu-msi.c :
> >
> >
> > static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = {
> >         .type   = IMX_MU_V2,
> >         .xTR    = 0x200,
> >         .xRR    = 0x280,
> >         .xSR    = {
> >                         [IMX_MU_SR]  = 0xC,
> >                         [IMX_MU_GSR] = 0x118,
> >                         [IMX_MU_GSR] = 0x124,    /* <--- issue here */
> >                         [IMX_MU_RSR] = 0x12C,
> >                   },
> >         .xCR    = {
> >                         [IMX_MU_GIER] = 0x110,
> >                         [IMX_MU_GCR]  = 0x114,
> >                         [IMX_MU_TCR]  = 0x120,
> >                         [IMX_MU_RCR]  = 0x128
> >                   },
> > };
> >
> > The .xSR object with index  IMX_MU_GSR is being set twice, once with
> > 0x118 and again with 0x128. I believe the first one should be
> > IMX_MU_TSR but w/o the datasheet I don't want to make any assumptions.
> 
> Huh, nice catch.
> 
> Frank, can you please provide a fix for this ASAP?
[Frank Li] Okay, will fix today. 

> 
> Thanks,
> 
>         M.
> 
> --
> Without deviation from the norm, progress is not possible.