linux-kernel - Re: [PATCH -next v3] pinctrl: ocelot: add missing destroy_workqueue() in error path in ocelot_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda6kCL-FbEdfu9msXH6xnLn9fLC-q6hcm=e_H_AT_uVEQ@mail.gmail.com>
Date:   Tue, 4 Oct 2022 21:57:58 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        p.zabel@...gutronix.de, horatiu.vultur@...rochip.com,
        andy.shevchenko@...il.com
Subject: Re: [PATCH -next v3] pinctrl: ocelot: add missing destroy_workqueue()
 in error path in ocelot_pinctrl_probe()

On Tue, Oct 4, 2022 at 1:46 PM Linus Walleij <linus.walleij@...aro.org> wrote:
> On Sun, Sep 25, 2022 at 4:06 AM Yang Yingliang <yangyingliang@...wei.com> wrote:
>
> > Using devm_add_action_or_reset() to make workqueue device-managed, so it can be
> > destroy whenever the driver is unbound.
> >
> > Fixes: c297561bc98a ("pinctrl: ocelot: Fix interrupt controller")
> > Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> > ---
> > v3:
> >   Using devm_add_action_or_reset().
>
> Patch applied, after deleting the hunks removing .remove because
> that was already gone upstream.

Ah, the patch introducing that is in the MFD tree is it not?

Either ask Lee to apply it or wait until -rc1 it's no big deal
anyway. Remind me in two weeks.

Yours,
Linus Walleij