linux-kernel - Re: [PATCH] mtd: dataflash: Remove duplicated id table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210050721.pyDn0aaI-lkp@intel.com>
Date:   Wed, 5 Oct 2022 07:29:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     Colin Ian King <colin.i.king@...il.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        u.kleine-koenig@...gutronix.de, Mark Brown <broonie@...nel.org>,
        linux-mtd@...ts.infradead.org
Cc:     kbuild-all@...ts.01.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: dataflash: Remove duplicated id table

Hi Colin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mtd/mtd/next]
[also build test WARNING on mtd/mtd/fixes linus/master v6.0 next-20221004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Colin-Ian-King/mtd-dataflash-Remove-duplicated-id-table/20221005-051450
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/26720a1a9258db8e7258181bbce5ff3767fbeed0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Colin-Ian-King/mtd-dataflash-Remove-duplicated-id-table/20221005-051450
        git checkout 26720a1a9258db8e7258181bbce5ff3767fbeed0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/mtd/devices/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/mtd/devices/mtd_dataflash.c:99:35: warning: 'dataflash_dev_ids' defined but not used [-Wunused-const-variable=]
      99 | static const struct spi_device_id dataflash_dev_ids[] = {
         |                                   ^~~~~~~~~~~~~~~~~


vim +/dataflash_dev_ids +99 drivers/mtd/devices/mtd_dataflash.c

1d6432fe10c3e7 David Brownell 2006-01-08   98  
27a030e8729255 Jon Hunter     2021-11-30  @99  static const struct spi_device_id dataflash_dev_ids[] = {
27a030e8729255 Jon Hunter     2021-11-30  100  	{ "at45" },
27a030e8729255 Jon Hunter     2021-11-30  101  	{ "dataflash" },
27a030e8729255 Jon Hunter     2021-11-30  102  	{ },
27a030e8729255 Jon Hunter     2021-11-30  103  };
27a030e8729255 Jon Hunter     2021-11-30  104  MODULE_DEVICE_TABLE(spi, dataflash_dev_ids);
27a030e8729255 Jon Hunter     2021-11-30  105  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (289525 bytes)