linux-kernel - Re: [PATCH] module: remove redundant module_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f4a62a2-4395-420f-0a20-e84c06b8c3ed@csgroup.eu>
Date:   Tue, 4 Oct 2022 04:35:43 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Luis Chamberlain <mcgrof@...nel.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
CC:     "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] module: remove redundant module_sysfs_initialized
 variable



Le 04/10/2022 à 01:40, Luis Chamberlain a écrit :
> On Thu, Sep 29, 2022 at 02:10:39PM +0200, Rasmus Villemoes wrote:
>> The variable module_sysfs_initialized is used for checking whether
>> module_kset has been initialized. Checking module_kset itself works
>> just fine for that.
>>
>> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> 
> Looks pretty sane to me, thanks! I'll queue this up for 6.2
> as we didn't get a chance to spin test this for 6.1 on linux-next.
> 

Maybe you can mention that this is a leftover from commit 7405c1e15edf 
("kset: convert /sys/module to use kset_create")

Christophe