linux-kernel - Re: [PATCH] module: remove redundant module_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yzxf2VlLaknhRdic@bombadil.infradead.org>
Date:   Tue, 4 Oct 2022 09:31:21 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     Rasmus Villemoes <linux@...musvillemoes.dk>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] module: remove redundant module_sysfs_initialized
 variable

On Tue, Oct 04, 2022 at 04:35:43AM +0000, Christophe Leroy wrote:
> 
> 
> Le 04/10/2022 à 01:40, Luis Chamberlain a écrit :
> > On Thu, Sep 29, 2022 at 02:10:39PM +0200, Rasmus Villemoes wrote:
> >> The variable module_sysfs_initialized is used for checking whether
> >> module_kset has been initialized. Checking module_kset itself works
> >> just fine for that.
> >>
> >> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> > 
> > Looks pretty sane to me, thanks! I'll queue this up for 6.2
> > as we didn't get a chance to spin test this for 6.1 on linux-next.
> > 
> 
> Maybe you can mention that this is a leftover from commit 7405c1e15edf 
> ("kset: convert /sys/module to use kset_create")

Sure, did that.

  Luis