| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPDyKFqwV27k5r8Pqo0bOqKQ2WKfcMdQoua665nA953U36+rXg@mail.gmail.com>
Date: Tue, 4 Oct 2022 17:15:20 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: juri.lelli@...hat.com, rafael@...nel.org, catalin.marinas@....com,
linus.walleij@...aro.org, bsegall@...gle.com, guoren@...nel.org,
pavel@....cz, agordeev@...ux.ibm.com, linux-arch@...r.kernel.org,
vincent.guittot@...aro.org, mpe@...erman.id.au,
chenhuacai@...nel.org, christophe.leroy@...roup.eu,
linux-acpi@...r.kernel.org, agross@...nel.org,
geert@...ux-m68k.org, linux-imx@....com, vgupta@...nel.org,
mattst88@...il.com, mturquette@...libre.com, sammy@...my.net,
pmladek@...e.com, linux-pm@...r.kernel.org,
Sascha Hauer <s.hauer@...gutronix.de>,
linux-um@...ts.infradead.org, npiggin@...il.com,
tglx@...utronix.de, linux-omap@...r.kernel.org,
dietmar.eggemann@....com, andreyknvl@...il.com,
gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
linux-perf-users@...r.kernel.org, senozhatsky@...omium.org,
svens@...ux.ibm.com, jolsa@...nel.org, tj@...nel.org,
Andrew Morton <akpm@...ux-foundation.org>,
mark.rutland@....com, linux-ia64@...r.kernel.org,
dave.hansen@...ux.intel.com,
virtualization@...ts.linux-foundation.org,
James.Bottomley@...senpartnership.com, jcmvbkbc@...il.com,
thierry.reding@...il.com, kernel@...0n.name, cl@...ux.com,
linux-s390@...r.kernel.org, vschneid@...hat.com,
john.ogness@...utronix.de, ysato@...rs.sourceforge.jp,
linux-sh@...r.kernel.org, festevam@...il.com, deller@....de,
daniel.lezcano@...aro.org, jonathanh@...dia.com, dennis@...nel.org,
lenb@...nel.org, linux-xtensa@...ux-xtensa.org,
kernel@...gutronix.de, gor@...ux.ibm.com,
linux-arm-msm@...r.kernel.org, linux-alpha@...r.kernel.org,
linux-m68k@...ts.linux-m68k.org, loongarch@...ts.linux.dev,
shorne@...il.com, chris@...kel.net, sboyd@...nel.org,
dinguyen@...nel.org, bristot@...hat.com,
alexander.shishkin@...ux.intel.com, fweisbec@...il.com,
lpieralisi@...nel.org, atishp@...shpatra.org,
linux@...musvillemoes.dk, kasan-dev@...glegroups.com,
will@...nel.org, boris.ostrovsky@...cle.com, khilman@...nel.org,
linux-csky@...r.kernel.org, pv-drivers@...are.com,
linux-snps-arc@...ts.infradead.org, mgorman@...e.de,
jacob.jun.pan@...ux.intel.com, Arnd Bergmann <arnd@...db.de>,
ulli.kroll@...glemail.com, linux-clk@...r.kernel.org,
rostedt@...dmis.org, ink@...assic.park.msu.ru, bcain@...cinc.com,
tsbogend@...ha.franken.de, linux-parisc@...r.kernel.org,
ryabinin.a.a@...il.com, sudeep.holla@....com, shawnguo@...nel.org,
davem@...emloft.net, dalias@...c.org, tony@...mide.com,
amakhalov@...are.com, konrad.dybcio@...ainline.org,
bjorn.andersson@...aro.org, glider@...gle.com, hpa@...or.com,
sparclinux@...r.kernel.org, linux-hexagon@...r.kernel.org,
linux-riscv@...ts.infradead.org, vincenzo.frascino@....com,
anton.ivanov@...bridgegreys.com, jonas@...thpole.se,
yury.norov@...il.com, richard@....at, x86@...nel.org,
linux@...linux.org.uk, mingo@...hat.com, aou@...s.berkeley.edu,
hca@...ux.ibm.com, richard.henderson@...aro.org,
stefan.kristiansson@...nalahti.fi, openrisc@...ts.librecores.org,
acme@...nel.org, paul.walmsley@...ive.com,
linux-tegra@...r.kernel.org, namhyung@...nel.org,
andriy.shevchenko@...ux.intel.com, jpoimboe@...nel.org,
dvyukov@...gle.com, jgross@...e.com, monstr@...str.eu,
linux-mips@...r.kernel.org, palmer@...belt.com,
anup@...infault.org, bp@...en8.de, johannes@...solutions.net,
linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 00/44] cpuidle,rcu: Clean up the mess
On Mon, 19 Sept 2022 at 12:18, Peter Zijlstra <peterz@...radead.org> wrote:
>
> Hi All!
>
> At long last, a respin of the cpuidle vs rcu cleanup patches.
>
> v1: https://lkml.kernel.org/r/20220608142723.103523089@infradead.org
>
> These here patches clean up the mess that is cpuidle vs rcuidle.
>
> At the end of the ride there's only on RCU_NONIDLE user left:
>
> arch/arm64/kernel/suspend.c: RCU_NONIDLE(__cpu_suspend_exit());
>
> and 'one' trace_*_rcuidle() user:
>
> kernel/trace/trace_preemptirq.c: trace_irq_enable_rcuidle(CALLER_ADDR0, CALLER_ADDR1);
> kernel/trace/trace_preemptirq.c: trace_irq_disable_rcuidle(CALLER_ADDR0, CALLER_ADDR1);
> kernel/trace/trace_preemptirq.c: trace_irq_enable_rcuidle(CALLER_ADDR0, caller_addr);
> kernel/trace/trace_preemptirq.c: trace_irq_disable_rcuidle(CALLER_ADDR0, caller_addr);
> kernel/trace/trace_preemptirq.c: trace_preempt_enable_rcuidle(a0, a1);
> kernel/trace/trace_preemptirq.c: trace_preempt_disable_rcuidle(a0, a1);
>
> However this last is all in deprecated code that should be unused for GENERIC_ENTRY.
>
> I've touched a lot of code that I can't test and I might've broken something by
> accident. In particular the whole ARM cpuidle stuff was quite involved.
>
> Please all; have a look where you haven't already.
>
>
> New since v1:
>
> - rebase on top of Frederic's rcu-context-tracking rename fest
> - more omap goodness as per the last discusion (thanks Tony!)
> - removed one more RCU_NONIDLE() from arm64/risc-v perf code
> - ubsan/kasan fixes
> - intel_idle module-param for testing
> - a bunch of extra __always_inline, because compilers are silly.
>
> ---
> arch/alpha/kernel/process.c | 1 -
> arch/alpha/kernel/vmlinux.lds.S | 1 -
> arch/arc/kernel/process.c | 3 ++
> arch/arc/kernel/vmlinux.lds.S | 1 -
> arch/arm/include/asm/vmlinux.lds.h | 1 -
> arch/arm/kernel/process.c | 1 -
> arch/arm/kernel/smp.c | 6 +--
> arch/arm/mach-gemini/board-dt.c | 3 +-
> arch/arm/mach-imx/cpuidle-imx6q.c | 4 +-
> arch/arm/mach-imx/cpuidle-imx6sx.c | 5 ++-
> arch/arm/mach-omap2/common.h | 6 ++-
> arch/arm/mach-omap2/cpuidle34xx.c | 16 +++++++-
> arch/arm/mach-omap2/cpuidle44xx.c | 29 +++++++-------
> arch/arm/mach-omap2/omap-mpuss-lowpower.c | 12 +++++-
> arch/arm/mach-omap2/pm.h | 2 +-
> arch/arm/mach-omap2/pm24xx.c | 51 +-----------------------
> arch/arm/mach-omap2/pm34xx.c | 14 +++++--
> arch/arm/mach-omap2/pm44xx.c | 2 +-
> arch/arm/mach-omap2/powerdomain.c | 10 ++---
> arch/arm64/kernel/idle.c | 1 -
> arch/arm64/kernel/smp.c | 4 +-
> arch/arm64/kernel/vmlinux.lds.S | 1 -
> arch/csky/kernel/process.c | 1 -
> arch/csky/kernel/smp.c | 2 +-
> arch/csky/kernel/vmlinux.lds.S | 1 -
> arch/hexagon/kernel/process.c | 1 -
> arch/hexagon/kernel/vmlinux.lds.S | 1 -
> arch/ia64/kernel/process.c | 1 +
> arch/ia64/kernel/vmlinux.lds.S | 1 -
> arch/loongarch/kernel/idle.c | 1 +
> arch/loongarch/kernel/vmlinux.lds.S | 1 -
> arch/m68k/kernel/vmlinux-nommu.lds | 1 -
> arch/m68k/kernel/vmlinux-std.lds | 1 -
> arch/m68k/kernel/vmlinux-sun3.lds | 1 -
> arch/microblaze/kernel/process.c | 1 -
> arch/microblaze/kernel/vmlinux.lds.S | 1 -
> arch/mips/kernel/idle.c | 8 ++--
> arch/mips/kernel/vmlinux.lds.S | 1 -
> arch/nios2/kernel/process.c | 1 -
> arch/nios2/kernel/vmlinux.lds.S | 1 -
> arch/openrisc/kernel/process.c | 1 +
> arch/openrisc/kernel/vmlinux.lds.S | 1 -
> arch/parisc/kernel/process.c | 2 -
> arch/parisc/kernel/vmlinux.lds.S | 1 -
> arch/powerpc/kernel/idle.c | 5 +--
> arch/powerpc/kernel/vmlinux.lds.S | 1 -
> arch/riscv/kernel/process.c | 1 -
> arch/riscv/kernel/vmlinux-xip.lds.S | 1 -
> arch/riscv/kernel/vmlinux.lds.S | 1 -
> arch/s390/kernel/idle.c | 1 -
> arch/s390/kernel/vmlinux.lds.S | 1 -
> arch/sh/kernel/idle.c | 1 +
> arch/sh/kernel/vmlinux.lds.S | 1 -
> arch/sparc/kernel/leon_pmc.c | 4 ++
> arch/sparc/kernel/process_32.c | 1 -
> arch/sparc/kernel/process_64.c | 3 +-
> arch/sparc/kernel/vmlinux.lds.S | 1 -
> arch/um/kernel/dyn.lds.S | 1 -
> arch/um/kernel/process.c | 1 -
> arch/um/kernel/uml.lds.S | 1 -
> arch/x86/boot/compressed/vmlinux.lds.S | 1 +
> arch/x86/coco/tdx/tdcall.S | 15 +------
> arch/x86/coco/tdx/tdx.c | 25 ++++--------
> arch/x86/events/amd/brs.c | 13 +++----
> arch/x86/include/asm/fpu/xcr.h | 4 +-
> arch/x86/include/asm/irqflags.h | 11 ++----
> arch/x86/include/asm/mwait.h | 14 +++----
> arch/x86/include/asm/nospec-branch.h | 2 +-
> arch/x86/include/asm/paravirt.h | 6 ++-
> arch/x86/include/asm/perf_event.h | 2 +-
> arch/x86/include/asm/shared/io.h | 4 +-
> arch/x86/include/asm/shared/tdx.h | 1 -
> arch/x86/include/asm/special_insns.h | 8 ++--
> arch/x86/include/asm/xen/hypercall.h | 2 +-
> arch/x86/kernel/cpu/bugs.c | 2 +-
> arch/x86/kernel/fpu/core.c | 4 +-
> arch/x86/kernel/paravirt.c | 14 ++++++-
> arch/x86/kernel/process.c | 65 +++++++++++++++----------------
> arch/x86/kernel/vmlinux.lds.S | 1 -
> arch/x86/lib/memcpy_64.S | 5 +--
> arch/x86/lib/memmove_64.S | 4 +-
> arch/x86/lib/memset_64.S | 4 +-
> arch/x86/xen/enlighten_pv.c | 2 +-
> arch/x86/xen/irq.c | 2 +-
> arch/xtensa/kernel/process.c | 1 +
> arch/xtensa/kernel/vmlinux.lds.S | 1 -
> drivers/acpi/processor_idle.c | 36 ++++++++++-------
> drivers/base/power/runtime.c | 24 ++++++------
> drivers/clk/clk.c | 8 ++--
> drivers/cpuidle/cpuidle-arm.c | 1 +
> drivers/cpuidle/cpuidle-big_little.c | 8 +++-
> drivers/cpuidle/cpuidle-mvebu-v7.c | 7 ++++
> drivers/cpuidle/cpuidle-psci.c | 10 +++--
> drivers/cpuidle/cpuidle-qcom-spm.c | 1 +
> drivers/cpuidle/cpuidle-riscv-sbi.c | 10 +++--
> drivers/cpuidle/cpuidle-tegra.c | 21 +++++++---
> drivers/cpuidle/cpuidle.c | 21 +++++-----
> drivers/cpuidle/dt_idle_states.c | 2 +-
> drivers/cpuidle/poll_state.c | 10 ++++-
> drivers/idle/intel_idle.c | 19 +++++----
> drivers/perf/arm_pmu.c | 11 +-----
> drivers/perf/riscv_pmu_sbi.c | 8 +---
> include/asm-generic/vmlinux.lds.h | 9 ++---
> include/linux/compiler_types.h | 8 +++-
> include/linux/cpu.h | 3 --
> include/linux/cpuidle.h | 34 ++++++++++++++++
> include/linux/cpumask.h | 4 +-
> include/linux/percpu-defs.h | 2 +-
> include/linux/sched/idle.h | 40 ++++++++++++++-----
> include/linux/thread_info.h | 18 ++++++++-
> include/linux/tracepoint.h | 13 ++++++-
> kernel/cpu_pm.c | 9 -----
> kernel/printk/printk.c | 2 +-
> kernel/sched/idle.c | 47 +++++++---------------
> kernel/time/tick-broadcast-hrtimer.c | 29 ++++++--------
> kernel/time/tick-broadcast.c | 6 ++-
> kernel/trace/trace.c | 3 ++
> lib/ubsan.c | 5 ++-
> mm/kasan/kasan.h | 4 ++
> mm/kasan/shadow.c | 38 ++++++++++++++++++
> tools/objtool/check.c | 17 ++++++++
> 121 files changed, 511 insertions(+), 420 deletions(-)
Thanks for cleaning up the situation!
I have applied this on a plain v6.0 (only one patch had a minor
conflict) and tested this on an ARM64 Dragonboard 410c, which uses
cpuidle-psci and the cpuidle-psci-domain. I didn't observe any
problems, so feel free to add:
Tested-by: Ulf Hansson <ulf.hansson@...aro.org>
Kind regards
Uffe
Powered by blists - more mailing lists