[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <19a54de8-d769-ab65-6332-6a8ff68e1437@quicinc.com>
Date: Tue, 4 Oct 2022 10:16:47 -0500
From: Melody Olvera <quic_molvera@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Stephen Boyd <sboyd@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Ulf Hansson <ulf.hansson@...aro.org>
CC: Bhupesh Sharma <bhupesh.sharma@...aro.org>,
<linux-arm-msm@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/5] dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs
and boards
On 10/1/2022 4:26 AM, Krzysztof Kozlowski wrote:
> On 01/10/2022 05:06, Melody Olvera wrote:
>> Document the QDU1000 and QRU1000 SoC bindings and the boards that use
>> them.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@...cinc.com>
>> ---
>> Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++
> This patch goes with DT.
Will move to the dt PS.
>
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index fb1d00bcc847..1cfd92f4ab5d 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -61,6 +61,8 @@ description: |
>> sm8250
>> sm8350
>> sm8450
>> + qdu1000
>> + qru1000
>>
>> The 'board' element must be one of the following strings:
>>
>> @@ -76,6 +78,7 @@ description: |
>> mtp
>> qrd
>> sbc
>> + x100
>>
>> The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
>> where the minor number may be omitted when it's zero, i.e. v1.0 is the same
>> @@ -718,6 +721,19 @@ properties:
>> - qcom,sm8450-qrd
>> - const: qcom,sm8450
>>
>> + - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
>> + - items:
>> + - enum:
>> + - qcom,qdu1000-idp
>> + - qcom,qdu1000-x100
>> + - const: qcom,qdu1000
> Wrong order - you put it in some odd place.
Will put in alphabetical order.
>
>> +
>> + - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
>> + - items:
>> + - enum:
>> + -qcom,qru1000-idp
> Missing space.
Whoops; will fix.
>
>> + - const: qcom,qru1000
>> +
>> additionalProperties: true
>>
>> ...
> Best regards,
> Krzysztof
Thanks,
Melody
Powered by blists - more mailing lists