linux-kernel - Re: [PATCH] net: benet: use snprintf instead sprintf and IFNAMSIZ instead hardcoded constant.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221004082936.0d0c9bcb@hermes.local>
Date:   Tue, 4 Oct 2022 08:29:36 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Peter Kosyh <pkosyh@...dex.ru>
Cc:     Ajit Khaparde <ajit.khaparde@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] net: benet: use snprintf instead sprintf and IFNAMSIZ
 instead hardcoded constant.

On Tue,  4 Oct 2022 12:50:34 +0300
Peter Kosyh <pkosyh@...dex.ru> wrote:

> printf to array 'eqo->desc' of size 32 may cause buffer overflow when
> using non-standard IFNAMSIZ.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Peter Kosyh <pkosyh@...dex.ru>

NACK
Non-standard IFNAMSIZ will break uapi and many things.
I see no reason for kernel or tools like iproute2 to support or
fix those related bugs.