[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20221004173046.5ec6d3ca@kernel.org>
Date: Tue, 4 Oct 2022 17:30:46 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stephen Hemminger <stephen@...workplumber.org>,
Peter Kosyh <pkosyh@...dex.ru>
Cc: Ajit Khaparde <ajit.khaparde@...adcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
Somnath Kotur <somnath.kotur@...adcom.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] net: benet: use snprintf instead sprintf and IFNAMSIZ
instead hardcoded constant.
On Tue, 4 Oct 2022 08:29:36 -0700 Stephen Hemminger wrote:
> On Tue, 4 Oct 2022 12:50:34 +0300
> Peter Kosyh <pkosyh@...dex.ru> wrote:
>
> > printf to array 'eqo->desc' of size 32 may cause buffer overflow when
> > using non-standard IFNAMSIZ.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
> > Signed-off-by: Peter Kosyh <pkosyh@...dex.ru>
>
> NACK
> Non-standard IFNAMSIZ will break uapi and many things.
> I see no reason for kernel or tools like iproute2 to support or
> fix those related bugs.
I think the commit message is missing the point, but the warning
may be legit.
Pater please read the requirements for sending patches based on
automated checkers:
Documentation/process/researcher-guidelines.rst
Powered by blists - more mailing lists