linux-kernel - Re: [PATCH v1 1/2] device property: Introduce fwnode_device_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210060108.UItKNQZU-lkp@intel.com>
Date:   Thu, 6 Oct 2022 01:52:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Qiang Zhao <qiang.zhao@....com>,
        Li Yang <leoyang.li@....com>,
        Daniel Scally <djrscally@...il.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH v1 1/2] device property: Introduce
 fwnode_device_is_compatible() helper

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on soc/for-next]
[also build test ERROR on linus/master v6.0 next-20221005]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/device-property-Introduce-fwnode_device_is_compatible-helper/20221005-223919
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: x86_64-rhel-8.3-kunit
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/b930d58084d15cbf92f0cd490ad05e843991bd8e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Andy-Shevchenko/device-property-Introduce-fwnode_device_is_compatible-helper/20221005-223919
        git checkout b930d58084d15cbf92f0cd490ad05e843991bd8e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 prepare

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/of.h:22,
                    from include/linux/irqdomain.h:35,
                    from arch/x86/include/asm/irqdomain.h:5,
                    from arch/x86/include/asm/msi.h:5,
                    from include/linux/msi.h:23,
                    from include/linux/kvm_host.h:19,
                    from arch/x86/kernel/../kvm/vmx/vmx.h:5,
                    from arch/x86/kernel/asm-offsets.c:22:
>> include/linux/property.h:54:6: warning: no previous prototype for 'fwnode_device_is_compatible' [-Wmissing-prototypes]
      54 | bool fwnode_device_is_compatible(const struct fwnode_handle *fwnode, const char *compat)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/property.h: In function 'fwnode_device_is_compatible':
>> include/linux/property.h:56:16: error: implicit declaration of function 'fwnode_property_match_string'; did you mean 'device_property_match_string'? [-Werror=implicit-function-declaration]
      56 |         return fwnode_property_match_string(fwnode, "compatible", compat) >= 0;
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                device_property_match_string
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1205: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:222: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +56 include/linux/property.h

    36	
    37	bool device_property_present(struct device *dev, const char *propname);
    38	int device_property_read_u8_array(struct device *dev, const char *propname,
    39					  u8 *val, size_t nval);
    40	int device_property_read_u16_array(struct device *dev, const char *propname,
    41					   u16 *val, size_t nval);
    42	int device_property_read_u32_array(struct device *dev, const char *propname,
    43					   u32 *val, size_t nval);
    44	int device_property_read_u64_array(struct device *dev, const char *propname,
    45					   u64 *val, size_t nval);
    46	int device_property_read_string_array(struct device *dev, const char *propname,
    47					      const char **val, size_t nval);
    48	int device_property_read_string(struct device *dev, const char *propname,
    49					const char **val);
    50	int device_property_match_string(struct device *dev,
    51					 const char *propname, const char *string);
    52	
    53	bool fwnode_device_is_available(const struct fwnode_handle *fwnode);
  > 54	bool fwnode_device_is_compatible(const struct fwnode_handle *fwnode, const char *compat)
    55	{
  > 56		return fwnode_property_match_string(fwnode, "compatible", compat) >= 0;
    57	}
    58	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (165134 bytes)