linux-kernel - Re: [PATCH] perf mem: Fix -C option behavior for perf mem record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yz5vUmZtQzYNRt73@leoy-yangtze.lan>
Date:   Thu, 6 Oct 2022 14:01:54 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-perf-users@...r.kernel.org,
        Kan Liang <kan.liang@...ux.intel.com>,
        Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH] perf mem: Fix -C option behavior for perf mem record

On Tue, Oct 04, 2022 at 01:02:11PM -0700, Namhyung Kim wrote:
> The -C/--cpu option was maily for report but it also affected record as
> it ate the option.  So users needed to use "--" after perf mem record to
> pass the info to the perf record properly.
> 
> Check if this option is set for record, and pass it to the actual perf
> record.
> 
> Before)
>   $ sudo perf --debug perf-event-open mem record -C 0 2>&1 | grep -a sys_perf_event_open
>   ...
>   sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0x8 = 4
>   sys_perf_event_open: pid -1  cpu 1  group_fd -1  flags 0x8 = 5
>   sys_perf_event_open: pid -1  cpu 2  group_fd -1  flags 0x8 = 6
>   sys_perf_event_open: pid -1  cpu 3  group_fd -1  flags 0x8 = 7
>   sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0x8 = 8
>   sys_perf_event_open: pid -1  cpu 1  group_fd -1  flags 0x8 = 9
>   sys_perf_event_open: pid -1  cpu 2  group_fd -1  flags 0x8 = 10
>   sys_perf_event_open: pid -1  cpu 3  group_fd -1  flags 0x8 = 11
>   ...
> 
> After)
>   $ sudo perf --debug perf-event-open mem record -C 0 2>&1 | grep -a sys_perf_event_open
>   ...
>   sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0x8 = 4
>   sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0x8 = 5
>   sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0x8 = 6
>   sys_perf_event_open: pid -1  cpu 0  group_fd -1  flags 0x8 = 7
> 
> Cc: Leo Yan <leo.yan@...aro.org>
> Reported-by: Ravi Bangoria <ravi.bangoria@....com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

The change LGTM:

Reviewed-by: Leo Yan <leo.yan@...aro.org>
Tested-by: Leo Yan <leo.yan@...aro.org>