linux-kernel - Re: [PATCH] ata: pata_mpc52xx: Replace NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80583d1d-4434-bd33-5fc7-7e72037e1ed4@opensource.wdc.com>
Date:   Thu, 6 Oct 2022 17:43:11 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0

On 10/6/22 17:37, Sergey Shtylyov wrote:
> Hello!
> 
>    Perhaps s/by/with/ in the subject?

I can fix that when applying.

> 
> On 10/6/22 8:17 AM, Christophe Leroy wrote:
> 
>> NO_IRQ is used to check the return of irq_of_parse_and_map().
>>
>> On some architecture NO_IRQ is 0, on other architectures it is -1.
>>
>> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>>
>> So use 0 instead of using NO_IRQ.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> 
> Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>
> 
> [...]
> 
> MBR, Sergey

-- 
Damien Le Moal
Western Digital Research