linux-kernel - Re: [PATCH] ata: pata_mpc52xx: Replace NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2022 11:43:01 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Sergey Shtylyov <s.shtylyov@....ru>
Cc:     linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0

On 10/6/22 14:17, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
> 
> On some architecture NO_IRQ is 0, on other architectures it is -1.
> 
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
> 
> So use 0 instead of using NO_IRQ.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> ---
>  drivers/ata/pata_mpc52xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
> index 6559b606736d..3ebd6522a1fd 100644
> --- a/drivers/ata/pata_mpc52xx.c
> +++ b/drivers/ata/pata_mpc52xx.c
> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
>  		udma_mask = ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
>  
>  	ata_irq = irq_of_parse_and_map(op->dev.of_node, 0);
> -	if (ata_irq == NO_IRQ) {
> +	if (!ata_irq) {
>  		dev_err(&op->dev, "error mapping irq\n");
>  		return -EINVAL;
>  	}

Applied to for-6.2. Thanks !

-- 
Damien Le Moal
Western Digital Research