linux-kernel - Re: [PATCH v5 2/6] iommu/s390: Get rid of s390_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 06 Oct 2022 17:19:44 +0200
From:   Niklas Schnelle <schnelle@...ux.ibm.com>
To:     Matthew Rosato <mjrosato@...ux.ibm.com>,
        Pierre Morel <pmorel@...ux.ibm.com>, iommu@...ts.linux.dev
Cc:     linux-s390@...r.kernel.org, borntraeger@...ux.ibm.com,
        hca@...ux.ibm.com, gor@...ux.ibm.com,
        gerald.schaefer@...ux.ibm.com, agordeev@...ux.ibm.com,
        svens@...ux.ibm.com, joro@...tes.org, will@...nel.org,
        robin.murphy@....com, jgg@...dia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/6] iommu/s390: Get rid of s390_domain_device

On Thu, 2022-10-06 at 16:46 +0200, Niklas Schnelle wrote:
> The struct s390_domain_device serves the sole purpose as list entry for
> the devices list of a struct s390_domain. As it contains no additional
> information besides a list_head and a pointer to the struct zpci_dev we
> can simplify things and just thread the device list through struct
> zpci_dev directly. This removes the need to allocate during domain
> attach and gets rid of one level of indirection during mapping
> operations.
> 
> Reviewed-by: Matthew Rosato <mjrosato@...ux.ibm.com>
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

@Jason, on second thought not sure if your R-b still holds as you only
implied that the zpci_unregister_ioat(), zdev->dma_table = NULL is okay
with the plan of ignoring zpci_register_ioat() fail on error in the
future (already have the patch).

> Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> ---
>  arch/s390/include/asm/pci.h |  1 +
>  drivers/iommu/s390-iommu.c  | 37 +++++++------------------------------
>  2 files changed, 8 insertions(+), 30 deletions(-)
---8<---