linux-kernel - Re: [PATCH 18/34] dt-bindings: pinctrl: qcom,msm8909-tlmm: minor style cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yz718g8yWxevNI34@gerhold.net>
Date:   Thu, 6 Oct 2022 17:36:18 +0200
From:   Stephan Gerhold <stephan@...hold.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawn.guo@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Vinod Koul <vkoul@...nel.org>,
        krishna Lanka <quic_vamslank@...cinc.com>,
        Iskren Chernev <iskren.chernev@...il.com>,
        Martin Botka <martin.botka@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/34] dt-bindings: pinctrl: qcom,msm8909-tlmm: minor
 style cleanups

On Thu, Oct 06, 2022 at 04:06:21PM +0200, Krzysztof Kozlowski wrote:
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently and drop redundant
> quotes.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Thanks for all the cleanup!

FWIW:
Acked-by: Stephan Gerhold <stephan@...hold.net>

> ---
>  .../bindings/pinctrl/qcom,msm8909-tlmm.yaml           | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> index 9c647e24fa9a..cc6d0c9c5100 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml
> @@ -10,8 +10,7 @@ maintainers:
>    - Stephan Gerhold <stephan@...hold.net>
>  
>  description: |
> -  This binding describes the Top Level Mode Multiplexer (TLMM) block found
> -  in the MSM8909 platform.
> +  Top Level Mode Multiplexer pin controller in Qualcomm MSM8909 SoC.
>  
>  allOf:
>    - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
> @@ -25,10 +24,10 @@ properties:
>  
>    interrupts: true
>    interrupt-controller: true
> -  '#interrupt-cells': true
> +  "#interrupt-cells": true
>    gpio-controller: true
>    gpio-reserved-ranges: true
> -  '#gpio-cells': true
> +  "#gpio-cells": true
>    gpio-ranges: true
>    wakeup-parent: true
>  
> @@ -39,7 +38,7 @@ required:
>  additionalProperties: false
>  
>  patternProperties:
> -  '-state$':
> +  "-state$":
>      oneOf:
>        - $ref: "#/$defs/qcom-msm8909-tlmm-state"
>        - patternProperties:
> @@ -53,7 +52,7 @@ $defs:
>      description:
>        Pinctrl node's client devices use subnodes for desired pin configuration.
>        Client device subnodes use below standard properties.
> -    $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state"
> +    $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state
>  
>      properties:
>        pins:
> -- 
> 2.34.1
>