linux-kernel - Re: [PATCH 00/34] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings (5th set)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yz75DAmjI1GbwQpI@gerhold.net>
Date:   Thu, 6 Oct 2022 17:49:32 +0200
From:   Stephan Gerhold <stephan@...hold.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawn.guo@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Vinod Koul <vkoul@...nel.org>,
        krishna Lanka <quic_vamslank@...cinc.com>,
        Iskren Chernev <iskren.chernev@...il.com>,
        Martin Botka <martin.botka@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/34] pinctrl/arm64: qcom: continued - fix Qualcomm TLMM
 pinctrl schema warnings (5th set)

Hi Krzysztof,

On Thu, Oct 06, 2022 at 04:06:03PM +0200, Krzysztof Kozlowski wrote:
> [...]
> Krzysztof Kozlowski (34):
>   dt-bindings: pinctrl: qcom,mdm9607: drop ref to pinctrl.yaml
>   dt-bindings: pinctrl: qcom,sc7280: drop checks used in common TLMM
>   dt-bindings: pinctrl: qcom,sc8180x: drop ref to pinctrl.yaml
>   dt-bindings: pinctrl: qcom,sc8180x: drop checks used in common TLMM
>   dt-bindings: pinctrl: qcom,sc8280xp: drop checks used in common TLMM
>   dt-bindings: pinctrl: qcom,sm6115: use common TLMM schema
>   dt-bindings: pinctrl: qcom,sm6125: drop checks used in common TLMM
>   dt-bindings: pinctrl: qcom,sm6125: drop ref to pinctrl.yaml
>   dt-bindings: pinctrl: qcom,sm6350: drop ref to pinctrl.yaml
>   dt-bindings: pinctrl: qcom,sm6350: drop checks used in common TLMM
>   dt-bindings: pinctrl: qcom,sm6375-tlmm: drop ref to pinctrl.yaml
>   dt-bindings: pinctrl: qcom,sm6375-tlmm: drop checks used in common
>     TLMM
>   dt-bindings: pinctrl: qcom,sm8250: use common TLMM schema
>   dt-bindings: pinctrl: qcom,sm8350: drop ref to pinctrl.yaml
>   dt-bindings: pinctrl: qcom,sm8350: drop checks used in common TLMM
>   dt-bindings: pinctrl: qcom,sm8450: drop checks used in common TLMM
>   dt-bindings: pinctrl: qcom,mdm9607: minor style cleanups
>   dt-bindings: pinctrl: qcom,msm8909-tlmm: minor style cleanups
>   dt-bindings: pinctrl: qcom,qcm2290: minor style cleanups
>   dt-bindings: pinctrl: qcom,sdx65: minor style cleanups
>   dt-bindings: pinctrl: qcom,sc8180x: minor style cleanups
>   dt-bindings: pinctrl: qcom,sc8280xp: minor style cleanups
>   dt-bindings: pinctrl: qcom,sm6115: minor style cleanups
>   dt-bindings: pinctrl: qcom,sm6125: minor style cleanups
>   dt-bindings: pinctrl: qcom,sm6350: minor style cleanups
>   dt-bindings: pinctrl: qcom,sm6375: minor style cleanups
>   dt-bindings: pinctrl: qcom,sm8250: minor style cleanups
>   dt-bindings: pinctrl: qcom,sm8350: minor style cleanups
>   dt-bindings: pinctrl: qcom,sm8450: minor style cleanups
>   dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: minor style cleanups
>   dt-bindings: pinctrl: qcom,sm8250-lpass-lpi: minor style cleanups
>   dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: minor style cleanups
>   dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: minor style cleanups
>   dt-bindings: pinctrl: qcom: adjust description
> 
>  .../pinctrl/qcom,ipq6018-pinctrl.yaml         |  5 +-
>  .../pinctrl/qcom,mdm9607-pinctrl.yaml         | 16 ++---
>  .../pinctrl/qcom,msm8226-pinctrl.yaml         |  5 +-
>  .../bindings/pinctrl/qcom,msm8909-tlmm.yaml   | 11 ++-
>  .../pinctrl/qcom,msm8953-pinctrl.yaml         |  5 +-
>  .../pinctrl/qcom,qcm2290-pinctrl.yaml         | 10 ++-
>  .../qcom,sc7280-lpass-lpi-pinctrl.yaml        | 13 ++--
>  .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 16 +----
>  .../pinctrl/qcom,sc8180x-pinctrl.yaml         | 27 +++----
>  .../qcom,sc8280xp-lpass-lpi-pinctrl.yaml      | 13 ++--
>  .../pinctrl/qcom,sc8280xp-pinctrl.yaml        | 22 ++----
>  .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml  |  5 +-
>  .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml  | 10 ++-
>  .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml | 53 +++-----------
>  .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml | 30 +++-----
>  .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 23 ++----
>  .../bindings/pinctrl/qcom,sm6375-tlmm.yaml    | 23 ++----
>  .../qcom,sm8250-lpass-lpi-pinctrl.yaml        | 16 ++---
>  .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 70 ++++++-------------
>  .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 23 ++----
>  .../qcom,sm8450-lpass-lpi-pinctrl.yaml        | 13 ++--
>  .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml | 22 ++----

Just a random thought since you are already doing minor style cleanups
here: Some of these files are named incorrectly, e.g. qcom,sm8450-pinctrl.yaml
actually documents "qcom,sm8450-tlmm". I noticed this while adding
qcom,msm8909-tlmm but I have to admit that it did not bother me enough
to actually prepare a patch for this (and now it would just conflict
with all your patches). :)

No need to change anything here, just thought I'd mention it.

Thanks!
Stephan