linux-kernel - Re: [PATCH] bpf: fix sample_flags for bpf_perf_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y0BDWK7cl83Fkwqz@hirez.programming.kicks-ass.net>
Date:   Fri, 7 Oct 2022 17:18:48 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Jiri Olsa <olsajiri@...il.com>
Cc:     Sumanth Korikkar <sumanthk@...ux.ibm.com>, bpf@...r.kernel.org,
        gor@...ux.ibm.com, hca@...ux.ibm.com, iii@...ux.ibm.com,
        linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org,
        namhyung@...nel.org, svens@...ux.ibm.com, tip-bot2@...utronix.de,
        tmricht@...ux.ibm.com, x86@...nel.org
Subject: Re: [PATCH] bpf: fix sample_flags for bpf_perf_event_output

On Fri, Oct 07, 2022 at 11:45:36AM +0200, Jiri Olsa wrote:
> On Fri, Oct 07, 2022 at 10:13:27AM +0200, Sumanth Korikkar wrote:
> > * Raw data is also filled by bpf_perf_event_output.
> > * Add sample_flags to indicate raw data.
> > * This eliminates the segfaults as shown below:
> >   Run ./samples/bpf/trace_output
> >   BUG pid 9 cookie 1001000000004 sized 4
> >   BUG pid 9 cookie 1001000000004 sized 4
> >   BUG pid 9 cookie 1001000000004 sized 4
> >   Segmentation fault (core dumped)
> > 
> > Fixes: 838d9bb62d13 ("perf: Use sample_flags for raw_data")
> > Acked-by: Namhyung Kim <namhyung@...nel.org>
> > Signed-off-by: Sumanth Korikkar <sumanthk@...ux.ibm.com>
> 
> Acked-by: Jiri Olsa <jolsa@...nel.org>
> 
> Peter,
> I think this should go through your tree again?
> bpf-next/master does not have sample_flags merged yet

Yep can do. I'll line it up in perf/urgent (Ingo just send out
perf/core).