linux-kernel - RE: [PATCH v2 1/2] xhci-pci: Set runtime PM as default policy on all xHC 1.2 or later devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN0PR12MB61013B3B55D21A49C2450B1AE25F9@MN0PR12MB6101.namprd12.prod.outlook.com>
Date:   Fri, 7 Oct 2022 16:42:36 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
CC:     Mathias Nyman <mathias.nyman@...el.com>,
        "Mehta, Sanju" <Sanju.Mehta@....com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] xhci-pci: Set runtime PM as default policy on all
 xHC 1.2 or later devices

[Public]



> -----Original Message-----
> From: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Sent: Friday, October 7, 2022 04:55
> To: Limonciello, Mario <Mario.Limonciello@....com>
> Cc: Mathias Nyman <mathias.nyman@...el.com>; Mehta, Sanju
> <Sanju.Mehta@....com>; Mathias Nyman
> <mathias.nyman@...ux.intel.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; linux-usb@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v2 1/2] xhci-pci: Set runtime PM as default policy on all
> xHC 1.2 or later devices
> 
> On Thu, Oct 06, 2022 at 04:15:28PM -0500, Mario Limonciello wrote:
> > -	if (pdev->vendor == PCI_VENDOR_ID_AMD &&
> > -	    (pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_1 ||
> > -	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_2 ||
> > -	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_3 ||
> > -	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_4 ||
> > -	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_5 ||
> > -	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_6 ||
> > -	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_7 ||
> > -	    pdev->device == PCI_DEVICE_ID_AMD_YELLOW_CARP_XHCI_8))
> 
> Can you add a comment here explaining why this is OK? I think it is
> easier that way to find out why this is here in the future instead of
> going through the git blame history.

Sure, no problem.

I'll hold off sending a v3 though until you and Mathias can double check
everything in patch 2/2 is OK to take out and agree with that secondary logic
change.

> 
> > +	if (xhci->hci_version >= 0x102)
> >  		xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;