linux-kernel - Re: [PATCH v1 2/2] dt-bindings: hpet: add loongson2k hpet binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80af028d-d123-6894-189a-a26134ec89ee@loongson.cn>
Date:   Sat, 8 Oct 2022 11:21:01 +0800
From:   Yinbo Zhu <zhuyinbo@...ngson.cn>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Jianmin Lv <lvjianmin@...ngson.cn>,
        Yun Liu <liuyun@...ngson.cn>,
        Yang Li <yang.lee@...ux.alibaba.com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        loongarch@...ts.linux.dev, zhuyinbo@...ngson.cn
Subject: Re: [PATCH v1 2/2] dt-bindings: hpet: add loongson2k hpet binding



在 2022/9/30 下午5:58, Krzysztof Kozlowski 写道:
> On 30/09/2022 11:35, Yinbo Zhu wrote:
>> Add the loongson2k High Precision Event Timer (HPET) binding
>> with DT schema format using json-schema.
>>
>> Signed-off-by: Yinbo Zhu <zhuyinbo@...ngson.cn>
>> ---
>>   .../bindings/timer/loongson,ls2k-hpet.yaml    | 41 +++++++++++++++++++
>>   MAINTAINERS                                   |  1 +
>>   2 files changed, 42 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
>> new file mode 100644
>> index 000000000000..1a8785076228
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
>> @@ -0,0 +1,41 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/timer/loongson,ls2k-hpet.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Loongson2k High Precision Event Timer (HPET)
>> +
>> +maintainers:
>> +  - Yinbo Zhu <zhuyinbo@...ngson.cn>
>> +
>> +properties:
>> +  compatible:
>> +    const: loongson,ls2k-hpet
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clock-frequency: true
> 
> clock frequency of what? I assume it's too early to use common clock
> framework and just get the clock?
The clock-frequency is 125000000, It doesn't support use common clock 
framework and just get the clock from dts, and I refer 
"arm,armv7m-systick" to add the clock-frequency information:

   clock-frequency: true

oneOf:
   - required:
       - clocks
   - required:
       - clock-frequency
> 
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clock-frequency
>> +  - interrupts
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    hpet0: hpet@...24000 {
> 
> Node name: timer
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
> You can drop the  "hpet0" label.
okay, I got it.
> 
> 
> Best regards,
> Krzysztof
>