linux-kernel - Re: [PATCH 7/8] serial: 8250/ingenic: Add support for the JZ4750/JZ4755 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2022 06:28:54 +0800
From:   kernel test robot <lkp@...el.com>
To:     Siarhei Volkau <lis8215@...il.com>
Cc:     kbuild-all@...ts.01.org, Siarhei Volkau <lis8215@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Paul Cercueil <paul@...pouillou.net>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jiri Slaby <jirislaby@...nel.org>, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        dmaengine@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 7/8] serial: 8250/ingenic: Add support for the
 JZ4750/JZ4755 SoCs

Hi Siarhei,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on robh/for-next vkoul-dmaengine/next linus/master v6.0 next-20221007]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Siarhei-Volkau/dt-bindings-ingenic-Add-support-for-the-JZ4755-SoC/20221010-031428
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: ia64-allyesconfig
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/d0252164e0fa9fdb0493eead109a4b24bd873a03
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Siarhei-Volkau/dt-bindings-ingenic-Add-support-for-the-JZ4755-SoC/20221010-031428
        git checkout d0252164e0fa9fdb0493eead109a4b24bd873a03
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/tty/serial/8250/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/tty/serial/8250/8250_ingenic.c: In function 'jz4750_early_console_setup':
   drivers/tty/serial/8250/8250_ingenic.c:142:34: error: implicit declaration of function 'CKSEG1ADDR' [-Werror=implicit-function-declaration]
     142 | #define CGU_REG_CPCCR   ((void *)CKSEG1ADDR(0x10000000))
         |                                  ^~~~~~~~~~
   drivers/tty/serial/8250/8250_ingenic.c:144:27: note: in expansion of macro 'CGU_REG_CPCCR'
     144 |         u32 cpccr = readl(CGU_REG_CPCCR);
         |                           ^~~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_ingenic.c:142:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     142 | #define CGU_REG_CPCCR   ((void *)CKSEG1ADDR(0x10000000))
         |                          ^
   drivers/tty/serial/8250/8250_ingenic.c:144:27: note: in expansion of macro 'CGU_REG_CPCCR'
     144 |         u32 cpccr = readl(CGU_REG_CPCCR);
         |                           ^~~~~~~~~~~~~
   {standard input}: Assembler messages:
   {standard input}:790: Error: Register number out of range 0..4
   {standard input}:791: Error: Register number out of range 0..4
   {standard input}:791: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 42
   {standard input}:791: Warning: Only the first path encountering the conflict is reported
   {standard input}:790: Warning: This is the location of the conflicting usage
   {standard input}:795: Error: Register number out of range 0..4
   cc1: some warnings being treated as errors


vim +142 drivers/tty/serial/8250/8250_ingenic.c

   138	
   139	static int __init jz4750_early_console_setup(struct earlycon_device *dev,
   140						     const char *opt)
   141	{
 > 142	#define CGU_REG_CPCCR	((void *)CKSEG1ADDR(0x10000000))
   143	#define CPCCR_ECS	BIT(30)
   144		u32 cpccr = readl(CGU_REG_CPCCR);
   145		int clk_div = (cpccr & CPCCR_ECS) ? 2 : 1;
   146	#undef CGU_REG_CPCCR
   147	#undef CPCCR_ECS
   148	
   149		return ingenic_earlycon_setup_common(dev, opt, clk_div);
   150	}
   151	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (319252 bytes)