linux-kernel - Re: [RFC PATCH 01/18] block: add and use init disk helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2022 00:59:01 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Chaitanya Kulkarni <kch@...dia.com>
Cc:     ogeert@...ux-m68k.org, linux-block@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
        drbd-dev@...ts.linbit.com, nbd@...er.debian.org,
        linux-mtd@...ts.infradead.org, axboe@...nel.dk,
        philipp.reisner@...bit.com, lars.ellenberg@...bit.com,
        christoph.boehmwalder@...bit.com, efremov@...ux.com,
        josef@...icpanda.com, tim@...erelk.net, haris.iqbal@...os.com,
        jinpu.wang@...os.com, richard@....at, miquel.raynal@...tlin.com,
        vigneshr@...com, mcgrof@...nel.org, hare@...e.de,
        damien.lemoal@...nsource.wdc.com, johannes.thumshirn@....com,
        bvanassche@....org, ming.lei@...hat.com, vincent.fu@...sung.com,
        shinichiro.kawasaki@....com
Subject: Re: [RFC PATCH 01/18] block: add and use init disk helper

On Tue, Oct 04, 2022 at 10:00:10PM -0700, Chaitanya Kulkarni wrote:
> +void init_disk(struct gendisk *disk, int major, int first_minor,
> +		int minors, sector_t sectors, void *private_data,
> +		const struct block_device_operations *fops)
> +{
> +	disk->major = major;
> +	disk->first_minor = first_minor;
> +	disk->minors = minors;
> +	set_capacity(disk, sectors);
> +	disk->private_data = private_data;
> +	disk->fops = fops;

I don't like this at all.  For one major/first_minor/minors are
optional and discouraged for new drivers.  Setting the capacity is
a different thing and is done by helpers also used for revalidation
in many drivers.

It might make sense to pass the fops (and maybe private_data) to
blk_mq_alloc_disk / blk_alloc_disk, but even then I'm not quite
sure it is worth the churn.