linux-kernel - Re: [RFC PATCH 01/18] block: add and use init disk helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2022 16:50:33 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Christoph Hellwig <hch@...radead.org>,
        Chaitanya Kulkarni <chaitanyak@...dia.com>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "christoph.boehmwalder@...bit.com" <christoph.boehmwalder@...bit.com>,
        "tim@...erelk.net" <tim@...erelk.net>,
        "damien.lemoal@...nsource.wdc.com" <damien.lemoal@...nsource.wdc.com>,
        "johannes.thumshirn@....com" <johannes.thumshirn@....com>,
        "bvanassche@....org" <bvanassche@....org>
Subject: Re: [RFC PATCH 01/18] block: add and use init disk helper

On 10/10/22 00:59, Christoph Hellwig wrote:
> On Tue, Oct 04, 2022 at 10:00:10PM -0700, Chaitanya Kulkarni wrote:
>> +void init_disk(struct gendisk *disk, int major, int first_minor,
>> +		int minors, sector_t sectors, void *private_data,
>> +		const struct block_device_operations *fops)
>> +{
>> +	disk->major = major;
>> +	disk->first_minor = first_minor;
>> +	disk->minors = minors;
>> +	set_capacity(disk, sectors);
>> +	disk->private_data = private_data;
>> +	disk->fops = fops;
> 
> I don't like this at all.  For one major/first_minor/minors are
> optional and discouraged for new drivers.  Setting the capacity is
> a different thing and is done by helpers also used for revalidation
> in many drivers.
> 
> It might make sense to pass the fops (and maybe private_data) to
> blk_mq_alloc_disk / blk_alloc_disk, but even then I'm not quite
> sure it is worth the churn.

Okay I'll drop this, and see if I can get something meaningful
with fops and private data.

-ck