[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 10 Oct 2022 13:32:51 +0000
From: Andrew Cooper <Andrew.Cooper3@...rix.com>
To: Florian Weimer <fweimer@...hat.com>
CC: Kees Cook <keescook@...omium.org>,
Rick Edgecombe <rick.p.edgecombe@...el.com>,
"x86@...nel.org" <x86@...nel.org>,
"H . Peter Anvin" <hpa@...or.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
Arnd Bergmann <arnd@...db.de>,
Andy Lutomirski <luto@...nel.org>,
Balbir Singh <bsingharora@...il.com>,
Borislav Petkov <bp@...en8.de>,
Cyrill Gorcunov <gorcunov@...il.com>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Eugene Syromiatnikov <esyr@...hat.com>,
"H . J . Lu" <hjl.tools@...il.com>, Jann Horn <jannh@...gle.com>,
Jonathan Corbet <corbet@....net>,
Mike Kravetz <mike.kravetz@...cle.com>,
Nadav Amit <nadav.amit@...il.com>,
Oleg Nesterov <oleg@...hat.com>, Pavel Machek <pavel@....cz>,
Peter Zijlstra <peterz@...radead.org>,
Randy Dunlap <rdunlap@...radead.org>,
"Ravi V . Shankar" <ravi.v.shankar@...el.com>,
Weijiang Yang <weijiang.yang@...el.com>,
"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
"joao.moreira@...el.com" <joao.moreira@...el.com>,
John Allen <john.allen@....com>,
"kcc@...gle.com" <kcc@...gle.com>,
"eranian@...gle.com" <eranian@...gle.com>,
"rppt@...nel.org" <rppt@...nel.org>,
"jamorris@...ux.microsoft.com" <jamorris@...ux.microsoft.com>,
"dethoma@...rosoft.com" <dethoma@...rosoft.com>,
Yu-cheng Yu <yu-cheng.yu@...el.com>,
Andrew Cooper <Andrew.Cooper3@...rix.com>
Subject: Re: [PATCH v2 18/39] mm: Add guard pages around a shadow stack.
On 10/10/2022 13:33, Florian Weimer wrote:
> * Andrew Cooper:
>
>> You don't actually need a hole to create a guard. Any mapping of type
>> != shstk will do.
>>
>> If you've got a load of threads, you can tightly pack stack / shstk /
>> stack / shstk with no holes, and they each act as each other guard pages.
> Can userspace read the shadow stack directly? Writing is obviously
> blocked, but reading?
Yes - regular reads are permitted to shstk memory.
It's actually a great way to get backtraces with no extra metadata needed.
> GCC's stack-clash probing uses OR instructions, so it would be fine with
> a readable mapping.
It's `or $0, (%rsp)` which is a read/modify/write and will fault when
hitting a shstk mapping.
> POSIX does not appear to require PROT_NONE mappings
> for the stack guard region, either. However, the
> pthread_attr_setguardsize manual page pretty clearly says that it's got
> to be unreadable and unwriteable. Hence my question.
Hmm. If that's what the manuals say, then fine.
But honestly, you don't get very far at all without faulting on a
read-only stack.
~Andrew
Powered by blists - more mailing lists